# Use testlib to skip t3300-funny-names 3 messages from 2006-01-05 to 2006-01-07. Participants: Alex Riesen, Junio C Hamano. Thread: https://gitlist.dev/t/2978 ## Alex Riesen, 2006-01-05 11:53 Subject: Use testlib to skip t3300-funny-names Message-ID: <81b0412b0601050353o6b96ed4fp2a6d24dd514cc9c2@mail.gmail.com> URL: https://gitlist.dev/e/81b0412b0601050353o6b96ed4fp2a6d24dd514cc9c2%40mail.gmail.com ``` The test cannot be run on cygwin anyway. Corrected the error message to reflect the problem source. Signed-off-by: Alex Riesen Subject: [PATCH] Use testlib to skip the test (it cannot be run on cygwin) Correct the error message to reflect the problem source Signed-off-by: Alex Riesen --- t/t3300-funny-names.sh | 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-) 721ca495bbbff1d387aa48ae401b7a14fb486ac0 diff --git a/t/t3300-funny-names.sh b/t/t3300-funny-names.sh index 6a85d67..5d70594 100755 --- a/t/t3300-funny-names.sh +++ b/t/t3300-funny-names.sh @@ -9,11 +9,15 @@ This test tries pathnames with funny cha tree, index, and tree objects. ' -# since FAT/NTFS does not allow tabs in filenames, skip this test -test "$(uname -o 2>/dev/null)" = Cygwin && exit 0 - . ./test-lib.sh +# Since FAT/NTFS does not allow tabs in filenames, skip this test. +# Windows also have unexplainable problems with names containing only spaces. +if [ "$(uname -o 2>/dev/null)" = Cygwin ]; then + say 'FAT and NTFS on Windows do not allow tabs in filenames, test skipped' + test_done +fi + p0='no-funny' p1='tabs ," (dq) and spaces' p2='just space' -- 1.0.GIT ``` ## Junio C Hamano, 2006-01-06 22:38 Subject: Re: Use testlib to skip t3300-funny-names Message-ID: <7vvewxq8xg.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vvewxq8xg.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <81b0412b0601050353o6b96ed4fp2a6d24dd514cc9c2@mail.gmail.com> ``` Alex Riesen writes: > The test cannot be run on cygwin anyway. > Corrected the error message to reflect the problem source. I'd rather see the test actually try to create a funny-named testfile and see if it managed to create it, so that it can be skipped on non DOS systems that mounted DOS filesystem. So instead I would do something like this: --- diff --git a/t/t3300-funny-names.sh b/t/t3300-funny-names.sh index 6a85d67..b1a86db 100755 --- a/t/t3300-funny-names.sh +++ b/t/t3300-funny-names.sh @@ -9,9 +9,6 @@ This test tries pathnames with funny cha tree, index, and tree objects. ' -# since FAT/NTFS does not allow tabs in filenames, skip this test -test "$(uname -o 2>/dev/null)" = Cygwin && exit 0 - . ./test-lib.sh p0='no-funny' @@ -27,6 +24,12 @@ EOF cat >"$p1" "$p0" echo 'Foo Bar Baz' >"$p2" +test -f "$p1" && cmp "$p0" "$p1" || { + # since FAT/NTFS does not allow tabs in filenames, skip this test + say 'Your filesystem does not allow tabs in filenames, test skipped.' + test_done +} + echo 'just space no-funny' >expected test_expect_success 'git-ls-files no-funny' \ ``` ## Alex Riesen, 2006-01-07 09:25 Subject: Re: Use testlib to skip t3300-funny-names Message-ID: <20060107092538.GA5536@steel.home> URL: https://gitlist.dev/e/20060107092538.GA5536%40steel.home In-Reply-To: <7vvewxq8xg.fsf@assigned-by-dhcp.cox.net> ``` Junio C Hamano, Fri, Jan 06, 2006 23:38:03 +0100: > > The test cannot be run on cygwin anyway. > > Corrected the error message to reflect the problem source. > > I'd rather see the test actually try to create a funny-named > testfile and see if it managed to create it, so that it can be > skipped on non DOS systems that mounted DOS filesystem. > > So instead I would do something like this: > > +test -f "$p1" && cmp "$p0" "$p1" || { > + # since FAT/NTFS does not allow tabs in filenames, skip this test > + say 'Your filesystem does not allow tabs in filenames, test skipped.' > + test_done > +} Yes, that's better ```