# [PATCH 1/2] post-receive-email: remove unused variable 4 messages from 2012-02-27 to 2012-02-27. Participants: mhagger@alum.mit.edu, Junio C Hamano. Thread: https://gitlist.dev/t/29761 ## mhagger@alum.mit.edu, 2012-02-27 18:34 Subject: [PATCH 0/2] Trivial cleanups in the post-receive-email script Message-ID: <1330367650-23091-1-git-send-email-mhagger@alum.mit.edu> URL: https://gitlist.dev/e/1330367650-23091-1-git-send-email-mhagger%40alum.mit.edu ``` From: Michael Haggerty Should be self-explanatory. Michael Haggerty (2): post-receive-email: remove unused variable post-receive-email: match up $LOGBEGIN..$LOGEND pairs correctly contrib/hooks/post-receive-email | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-) -- 1.7.9 ``` ## mhagger@alum.mit.edu, 2012-02-27 18:34 Subject: [PATCH 1/2] post-receive-email: remove unused variable Message-ID: <1330367650-23091-2-git-send-email-mhagger@alum.mit.edu> URL: https://gitlist.dev/e/1330367650-23091-2-git-send-email-mhagger%40alum.mit.edu In-Reply-To: <1330367650-23091-1-git-send-email-mhagger@alum.mit.edu> ``` From: Michael Haggerty prep_for_email neither is passed a fourth argument nor uses it. Signed-off-by: Michael Haggerty --- contrib/hooks/post-receive-email | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email index ba077c1..ac2e0ed 100755 --- a/contrib/hooks/post-receive-email +++ b/contrib/hooks/post-receive-email @@ -85,7 +85,6 @@ prep_for_email() oldrev=$(git rev-parse $1) newrev=$(git rev-parse $2) refname="$3" - maxlines=$4 # --- Interpret # 0000->1234 (create) -- 1.7.9 ``` ## mhagger@alum.mit.edu, 2012-02-27 18:34 Subject: [PATCH 2/2] post-receive-email: match up $LOGBEGIN..$LOGEND pairs correctly Message-ID: <1330367650-23091-3-git-send-email-mhagger@alum.mit.edu> URL: https://gitlist.dev/e/1330367650-23091-3-git-send-email-mhagger%40alum.mit.edu In-Reply-To: <1330367650-23091-1-git-send-email-mhagger@alum.mit.edu> ``` From: Michael Haggerty Signed-off-by: Michael Haggerty --- contrib/hooks/post-receive-email | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email index ac2e0ed..01af9df 100755 --- a/contrib/hooks/post-receive-email +++ b/contrib/hooks/post-receive-email @@ -460,7 +460,7 @@ generate_delete_branch_email() { echo " was $oldrev" echo "" - echo $LOGEND + echo $LOGBEGIN git show -s --pretty=oneline $oldrev echo $LOGEND } @@ -560,7 +560,7 @@ generate_delete_atag_email() { echo " was $oldrev" echo "" - echo $LOGEND + echo $LOGBEGIN git show -s --pretty=oneline $oldrev echo $LOGEND } @@ -625,7 +625,7 @@ generate_delete_general_email() { echo " was $oldrev" echo "" - echo $LOGEND + echo $LOGBEGIN git show -s --pretty=oneline $oldrev echo $LOGEND } -- 1.7.9 ``` ## Junio C Hamano, 2012-02-27 19:01 Subject: Re: [PATCH 0/2] Trivial cleanups in the post-receive-email script Message-ID: <7vlino85ji.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vlino85ji.fsf%40alter.siamese.dyndns.org In-Reply-To: <1330367650-23091-1-git-send-email-mhagger@alum.mit.edu> ``` Shows that nobody uses these sample script. Will apply. I wish all the patches were this easy ;-). Thanks. ```