# [PATCH] pack-objects: Fix compilation with NO_PTHREDS 3 messages from 2012-02-25 to 2012-02-25. Participants: Michał Kiedrowicz, Junio C Hamano, Nguyen Thai Ngoc Duy. Thread: https://gitlist.dev/t/29731 ## Michał Kiedrowicz, 2012-02-25 08:16 Subject: [PATCH] pack-objects: Fix compilation with NO_PTHREDS Message-ID: <1330157769-7884-1-git-send-email-michal.kiedrowicz@gmail.com> URL: https://gitlist.dev/e/1330157769-7884-1-git-send-email-michal.kiedrowicz%40gmail.com ``` It looks like commit 99fb6e04 (pack-objects: convert to use parse_options(), 2012-02-01) moved the #ifdef NO_PTHREDS around but hasn't noticed that the 'arg' variable no longer is available. Signed-off-by: Michał Kiedrowicz --- builtin/pack-objects.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c index db09cf7..71af246 100644 --- a/builtin/pack-objects.c +++ b/builtin/pack-objects.c @@ -2449,7 +2449,7 @@ int cmd_pack_objects(int argc, const char **argv, const char *prefix) die("bad pack compression level %d", pack_compression_level); #ifdef NO_PTHREADS if (delta_search_threads != 1) - warning("no threads support, ignoring %s", arg); + warning("no threads support, ignoring --threads"); #endif if (!pack_to_stdout && !pack_size_limit) pack_size_limit = pack_size_limit_cfg; -- 1.7.8.4 ``` ## Junio C Hamano, 2012-02-25 09:02 Subject: Re: [PATCH] pack-objects: Fix compilation with NO_PTHREDS Message-ID: <7vty2fffpp.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vty2fffpp.fsf%40alter.siamese.dyndns.org In-Reply-To: <1330157769-7884-1-git-send-email-michal.kiedrowicz@gmail.com> ``` Michał Kiedrowicz writes: > It looks like commit 99fb6e04 (pack-objects: convert to use > parse_options(), 2012-02-01) moved the #ifdef NO_PTHREDS around but > hasn't noticed that the 'arg' variable no longer is available. > > Signed-off-by: Michał Kiedrowicz Thanks. Nguyễn, a quick double-check and an Ack? > --- > builtin/pack-objects.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c > index db09cf7..71af246 100644 > --- a/builtin/pack-objects.c > +++ b/builtin/pack-objects.c > @@ -2449,7 +2449,7 @@ int cmd_pack_objects(int argc, const char **argv, const char *prefix) > die("bad pack compression level %d", pack_compression_level); > #ifdef NO_PTHREADS > if (delta_search_threads != 1) > - warning("no threads support, ignoring %s", arg); > + warning("no threads support, ignoring --threads"); > #endif > if (!pack_to_stdout && !pack_size_limit) > pack_size_limit = pack_size_limit_cfg; ``` ## Nguyen Thai Ngoc Duy, 2012-02-25 09:24 Subject: Re: [PATCH] pack-objects: Fix compilation with NO_PTHREDS Message-ID: URL: https://gitlist.dev/e/CACsJy8CrVEQ%2BvCXyXhGry5tRwYoyc7NHeOJg7UXCTPF%2B50sexA%40mail.gmail.com In-Reply-To: <7vty2fffpp.fsf@alter.siamese.dyndns.org> ``` 2012/2/25 Junio C Hamano : > Michał Kiedrowicz writes: > >> It looks like commit 99fb6e04 (pack-objects: convert to use >> parse_options(), 2012-02-01) moved the #ifdef NO_PTHREDS around but >> hasn't noticed that the 'arg' variable no longer is available. >> >> Signed-off-by: Michał Kiedrowicz > > Thanks.  Nguyễn, a quick double-check and an Ack? Tested and acked. -- Duy ```