# [PATCH] builtin/tag.c: Fix a sparse warning

2 messages from 2012-02-13 to 2012-02-13. Participants: Ramsay Jones, Tom Grennan.
Thread: https://gitlist.dev/t/29616

## Ramsay Jones, 2012-02-13 18:24

Subject: [PATCH] builtin/tag.c: Fix a sparse warning
Message-ID: <4F395569.8030106@ramsay1.demon.co.uk>
URL: https://gitlist.dev/e/4F395569.8030106%40ramsay1.demon.co.uk

```

In particular, sparse complains as follows:

        SP builtin/tag.c
    builtin/tag.c:411:5: warning: symbol 'parse_opt_points_at' was \
        not declared. Should it be static?

In order to suppress the warning, since the parse_opt_points_at()
function does not need to be an external symbol, we simply add the
static modifier to the function definition.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---

 builtin/tag.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/builtin/tag.c b/builtin/tag.c
index 8cfaaf8..fe7e5e5 100644
--- a/builtin/tag.c
+++ b/builtin/tag.c
@@ -408,7 +408,7 @@ static int strbuf_check_tag_ref(struct strbuf *sb, const char *name)
 	return check_refname_format(sb->buf, 0);
 }
 
-int parse_opt_points_at(const struct option *opt __attribute__ ((unused)),
+static int parse_opt_points_at(const struct option *opt __attribute__((unused)),
 			const char *arg, int unset)
 {
 	unsigned char sha1[20];
-- 
1.7.9

```

## Tom Grennan, 2012-02-13 19:15

Subject: Re: [PATCH] builtin/tag.c: Fix a sparse warning
Message-ID: <20120213191459.GA2707@tgrennan-laptop>
URL: https://gitlist.dev/e/20120213191459.GA2707%40tgrennan-laptop
In-Reply-To: <4F395569.8030106@ramsay1.demon.co.uk>

```
On Mon, Feb 13, 2012 at 06:24:41PM +0000, Ramsay Jones wrote:
>
>In particular, sparse complains as follows:
>
>        SP builtin/tag.c
>    builtin/tag.c:411:5: warning: symbol 'parse_opt_points_at' was \
>        not declared. Should it be static?
>
>In order to suppress the warning, since the parse_opt_points_at()
>function does not need to be an external symbol, we simply add the
>static modifier to the function definition.
>
>Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>

Acked-by: Tom Grennan <tmgrennan@gmail.com>

Thanks

>---
>
> builtin/tag.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/builtin/tag.c b/builtin/tag.c
>index 8cfaaf8..fe7e5e5 100644
>--- a/builtin/tag.c
>+++ b/builtin/tag.c
>@@ -408,7 +408,7 @@ static int strbuf_check_tag_ref(struct strbuf *sb, const char *name)
> 	return check_refname_format(sb->buf, 0);
> }
> 
>-int parse_opt_points_at(const struct option *opt __attribute__ ((unused)),
>+static int parse_opt_points_at(const struct option *opt __attribute__((unused)),
> 			const char *arg, int unset)
> {
> 	unsigned char sha1[20];
>-- 
>1.7.9
>
>

```