threads / discuss / 29521

Re: Finding all commits which modify a file

Subject: Re: Finding all commits which modify a file

## tl;dr

2 messages between Feb 2, 2012 and Feb 2, 2012.

replies: 1people: 2as markdown or json

Neal Groothuis· Feb 2, 2012, 14:55 UTC · lore
Show 7 quoted lines
> "Neal Groothuis" <ngroot@lo-cal.org> writes:
>
>> Is there a situation where checking for TREESAMEness before
>> simplification
>> is desirable and checking after would not be?
>
> When you do not want to see a side branch that does not contribute to

the end result at all, obviously ;-). Outside that situation, before or after should not make a difference, I would think.

In that case, you wouldn't be using the --full-history flag at all, yeah?

Right now, we can see where the file gets changed (A1), we just can't see where it gets changed back (B2). In fact, if I run git-log --full-history --simplify-merges foo.txt, it looks like A1 was the last thing to make changes to foo.txt, which seems misleading to me---history has been simplified to the point of not being true.

Junio C Hamano· Feb 2, 2012, 19:13 UTC · re: Neal Groothuis · lore
"Neal Groothuis" <ngroot@lo-cal.org> writes:
Show 11 quoted lines
>> "Neal Groothuis" <ngroot@lo-cal.org> writes:
>>
>>> Is there a situation where checking for TREESAMEness before
>>> simplification
>>> is desirable and checking after would not be?
>>
>> When you do not want to see a side branch that does not contribute to
> the end result at all, obviously ;-). Outside that situation, before or
> after should not make a difference, I would think.
>
> In that case, you wouldn't be using the --full-history flag at all, yeah?

Yes. In case my tongue-in-cheek comment was too obscure, I was saying that I do not think the change to TREESAME-ness check you were alluding to would break any use case I would think of off the top of my head.

We of course might discover undesired consequences in unexpected corners after we try your change, but I do not think we can discuss such corner cases further without seeing a patch.

← back to recent threads