threads / patch / 2947

patchgitk - show newly created files

Subject: [PATCH] gitk - show newly created files

## tl;dr

One message between Dec 31, 2005 and Dec 31, 2005. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Alecs King· Dec 31, 2005, 08:14 UTC · lore
When specifying a filename as an argument to gitk, ie.
$ gitk apply.c
gitk does not show the diff when the file newly created.  

That 'newly created' commit is the last one gitk gets from 'git-rev-list' so gitk thinks it has no parent while it normally does (except that the commit itself is the root commit).

This patch is to (try to) fix this problem.
P.S, is it good if gitk also has a '--root' option like git-whatchanged?
Signed-off-by: Alecs King <alecsk@gmail.com>
Show changes to gitk +3 −3
diff --git a/gitk b/gitk
index f12b3ce..688ee12 100755
--- a/gitk
+++ b/gitk
@@ -2288,10 +2288,10 @@ proc selectline {l isnew} {
 
     $cflist delete 0 end
     $cflist insert end "Comments"
-    if {$nparents($id) == 1} {
-	startdiff $id
-    } elseif {$nparents($id) > 1} {
+    if {$nparents($id) > 1} {
 	mergediff $id
+    } else {
+        startdiff $id
     }
 }
 
-- 
Alecs King

← back to recent threads