# [PATCH] Do not allow git-init-db to be called twice in the same directory 5 messages from 2005-12-26 to 2005-12-27. Participants: Johannes Schindelin, Junio C Hamano. Thread: https://gitlist.dev/t/2934 ## Johannes Schindelin, 2005-12-26 23:54 Subject: [PATCH] Do not allow git-init-db to be called twice in the same directory Message-ID: URL: https://gitlist.dev/e/Pine.LNX.4.63.0512270053030.14928%40wbgn013.biozentrum.uni-wuerzburg.de ``` t5300 is also adapted, since it relies heavily on init-db not complaining when $GIT_DIR already exists. Signed-off-by: Johannes Schindelin --- init-db.c | 3 ++- t/t5300-pack-object.sh | 16 ++++++---------- 2 files changed, 8 insertions(+), 11 deletions(-) 199557e282c6b7600fdb9f7ce8b203b1d634de8f diff --git a/init-db.c b/init-db.c index ff29496..1cb015e 100644 --- a/init-db.c +++ b/init-db.c @@ -259,7 +259,8 @@ int main(int argc, char **argv) git_dir = DEFAULT_GIT_DIR_ENVIRONMENT; fprintf(stderr, "defaulting to local storage area\n"); } - safe_create_dir(git_dir, 0); + if (mkdir(git_dir, 0777) < 0) + die("Cannot initialize repository twice!"); /* Check to see if the repository version is right. * Note that a newly created repository does not have diff --git a/t/t5300-pack-object.sh b/t/t5300-pack-object.sh index 7dfb1ab..df6549c 100755 --- a/t/t5300-pack-object.sh +++ b/t/t5300-pack-object.sh @@ -38,13 +38,12 @@ test_expect_success \ 'packname_1=$(git-pack-objects --window=0 test-1 current && diff expect current' - test_expect_success \ 'use packed deltified objects' \ 'GIT_OBJECT_DIRECTORY=.git2/objects && -- 1.0.GIT ``` ## Junio C Hamano, 2005-12-27 01:18 Subject: Re: [PATCH] Do not allow git-init-db to be called twice in the same directory Message-ID: <7vbqz3ibhn.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vbqz3ibhn.fsf%40assigned-by-dhcp.cox.net In-Reply-To: ``` Johannes Schindelin writes: > t5300 is also adapted, since it relies heavily on init-db not complaining > when $GIT_DIR already exists. I think it tries not to overwrite things that are already there and is meant to be safe to run in an already populated repository; e.g. you should be able to use it to pick up newly added templates. Is there a particular reason running the current init-db twice is undesirable? ``` ## Johannes Schindelin, 2005-12-27 14:01 Subject: Re: [PATCH] Do not allow git-init-db to be called twice in the same directory Message-ID: URL: https://gitlist.dev/e/Pine.LNX.4.63.0512271457200.17086%40wbgn013.biozentrum.uni-wuerzburg.de In-Reply-To: <7vbqz3ibhn.fsf@assigned-by-dhcp.cox.net> ``` Hi, On Mon, 26 Dec 2005, Junio C Hamano wrote: > Johannes Schindelin writes: > > > t5300 is also adapted, since it relies heavily on init-db not complaining > > when $GIT_DIR already exists. > > I think it tries not to overwrite things that are already there > and is meant to be safe to run in an already populated > repository; e.g. you should be able to use it to pick up newly > added templates. Ah, that is a use case I missed. I don't work too much with templates (only on the shared repositories' machine)... > Is there a particular reason running the current init-db twice > is undesirable? In my case, yes. When I do that, it means that I did not correctly change directories. I fscked up my private git repository twice that way. I like your point, though. Ciao, Dscho ``` ## Junio C Hamano, 2005-12-27 16:47 Subject: Re: [PATCH] Do not allow git-init-db to be called twice in the same directory Message-ID: <7vlky6bi6f.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vlky6bi6f.fsf%40assigned-by-dhcp.cox.net In-Reply-To: ``` Johannes Schindelin writes: >> Is there a particular reason running the current init-db twice >> is undesirable? > > In my case, yes. When I do that, it means that I did not correctly > change directories. I fscked up my private git repository twice that way. Maybe a warning (e.g. "rerunning in an already set up repository") is in order? ``` ## Johannes Schindelin, 2005-12-27 18:01 Subject: Re: [PATCH] Do not allow git-init-db to be called twice in the same directory Message-ID: URL: https://gitlist.dev/e/Pine.LNX.4.63.0512271859250.1618%40wbgn013.biozentrum.uni-wuerzburg.de In-Reply-To: <7vlky6bi6f.fsf@assigned-by-dhcp.cox.net> ``` Hi, On Tue, 27 Dec 2005, Junio C Hamano wrote: > Johannes Schindelin writes: > > >> Is there a particular reason running the current init-db twice > >> is undesirable? > > > > In my case, yes. When I do that, it means that I did not correctly > > change directories. I fscked up my private git repository twice that way. > > Maybe a warning (e.g. "rerunning in an already set up > repository") is in order? Yeah. Or a command line parameter "--exists" without which it fails? Ciao, Dscho ```