# [PATCH] builtin/init-db.c: eliminate -Wformat warning on Solaris 2 messages from 2011-12-20 to 2011-12-21. Participants: Ævar Arnfjörð Bjarmason, Junio C Hamano. Thread: https://gitlist.dev/t/29216 ## Ævar Arnfjörð Bjarmason, 2011-12-20 23:27 Subject: [PATCH] builtin/init-db.c: eliminate -Wformat warning on Solaris Message-ID: <1324423661-31174-1-git-send-email-avarab@gmail.com> URL: https://gitlist.dev/e/1324423661-31174-1-git-send-email-avarab%40gmail.com ``` On Solaris systems we'd warn about an implicit cast of mode_t when we printed things out with the %d format. We'd get this warning under GCC 4.6.0 with Solaris headers: builtin/init-db.c: In function ‘separate_git_dir’: builtin/init-db.c:354:4: warning: format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘mode_t’ [-Wformat] We've been doing this ever since v1.7.4.1-296-gb57fb80. Just work around this by adding an explicit cast. Signed-off-by: Ævar Arnfjörð Bjarmason --- builtin/init-db.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/builtin/init-db.c b/builtin/init-db.c index d07554c..0dacb8b 100644 --- a/builtin/init-db.c +++ b/builtin/init-db.c @@ -351,7 +351,7 @@ static void separate_git_dir(const char *git_dir) else if (S_ISDIR(st.st_mode)) src = git_link; else - die(_("unable to handle file type %d"), st.st_mode); + die(_("unable to handle file type %d"), (int)st.st_mode); if (rename(src, git_dir)) die_errno(_("unable to move %s to %s"), src, git_dir); -- 1.7.7.3 ``` ## Junio C Hamano, 2011-12-21 00:04 Subject: Re: [PATCH] builtin/init-db.c: eliminate -Wformat warning on Solaris Message-ID: <7vmxamiyda.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vmxamiyda.fsf%40alter.siamese.dyndns.org In-Reply-To: <1324423661-31174-1-git-send-email-avarab@gmail.com> ``` I will queue this directly on 'maint', as I do not think it is worth fixing immediately on top of 2c050e0 (i18n: mark init-db messages for translation, 2011-04-10) and merging all the way down to the now-ancient v1.7.5.X series. Thanks. ```