# Re: [PATCH] tag deletions not rejected with receive.denyDeletes= true

2 messages from 2011-12-12 to 2011-12-12. Participants: Jerome DE VIVIE, Junio C Hamano.
Thread: https://gitlist.dev/t/29138

## Jerome DE VIVIE, 2011-12-12 14:06

Subject: Re: [PATCH] tag deletions not rejected with receive.denyDeletes= true
Message-ID: <12967682.2821323698766430.JavaMail.root@promailix.prometil.com>
URL: https://gitlist.dev/e/12967682.2821323698766430.JavaMail.root%40promailix.prometil.com
In-Reply-To: <6271653.2751323698446271.JavaMail.root@promailix.prometil.com>

```

Junio C Hamano <gitster@pobox.com> writes :
> Our documentation can also use some updates, as it dates to the days back
> when we more liberally used "refs" and "branches" interchangeably.

Ok, I have turned the patch below for documentation.

For protecting tags, I can do it with triggers but its painful with lots of repositories. I propose to extend receive.denyDeletes with these values:
- "false"/"none" (existing behavior)
- "true"/"branches" (existing behavior)
- "tags": protect tags only
- "all": protect both tags and branches

Your opinion ?

BR
Jérôme


Signed-off-by: Jerome de Vivie <jedevivie-ext@airfrance.fr>
---
 Documentation/config.txt |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Documentation/config.txt b/Documentation/config.txt
index 5a841da..9c7c7fe 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt
@@ -1642,7 +1642,7 @@ receive.unpackLimit::
 
 receive.denyDeletes::
 	If set to true, git-receive-pack will deny a ref update that deletes
-	the ref. Use this to prevent such a ref deletion via a push.
+	a branch. Use this to prevent such a branch deletion via a push.
 
 receive.denyDeleteCurrent::
 	If set to true, git-receive-pack will deny a ref update that
-- 
1.7.6.msysgit.0

```

## Junio C Hamano, 2011-12-12 17:16

Subject: Re: [PATCH] tag deletions not rejected with receive.denyDeletes= true
Message-ID: <7v62hl677n.fsf@alter.siamese.dyndns.org>
URL: https://gitlist.dev/e/7v62hl677n.fsf%40alter.siamese.dyndns.org
In-Reply-To: <12967682.2821323698766430.JavaMail.root@promailix.prometil.com>

```
Jerome DE VIVIE <j.devivie@prometil.com> writes:

> Junio C Hamano <gitster@pobox.com> writes :
>> Our documentation can also use some updates, as it dates to the days back
>> when we more liberally used "refs" and "branches" interchangeably.
>
> Ok, I have turned the patch below for documentation.

Err,.. what I meant by "documentation update" is more like this.

 Documentation/config.txt |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/config.txt b/Documentation/config.txt
index 8a7d2d4..8eda8e4 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt
@@ -1653,15 +1653,15 @@ receive.unpackLimit::
 	`transfer.unpackLimit` is used instead.
 
 receive.denyDeletes::
-	If set to true, git-receive-pack will deny a ref update that deletes
-	the ref. Use this to prevent such a ref deletion via a push.
+	If set to true, git-receive-pack will deny an update that deletes
+	the branch. Use this to prevent a push from deleting a branch.
 
 receive.denyDeleteCurrent::
-	If set to true, git-receive-pack will deny a ref update that
+	If set to true, git-receive-pack will deny an update that
 	deletes the currently checked out branch of a non-bare repository.
 
 receive.denyCurrentBranch::
-	If set to true or "refuse", git-receive-pack will deny a ref update
+	If set to true or "refuse", git-receive-pack will deny an update
 	to the currently checked out branch of a non-bare repository.
 	Such a push is potentially dangerous because it brings the HEAD
 	out of sync with the index and working tree. If set to "warn",

```
