# [PATCH] am: don't persist keepcr flag

2 messages from 2011-12-09 to 2011-12-09. Participants: Martin von Zweigbergk, Junio C Hamano.
Thread: https://gitlist.dev/t/29113

## Martin von Zweigbergk, 2011-12-09 07:30

Subject: [PATCH] am: don't persist keepcr flag
Message-ID: <1323415845-11826-1-git-send-email-martin.von.zweigbergk@gmail.com>
URL: https://gitlist.dev/e/1323415845-11826-1-git-send-email-martin.von.zweigbergk%40gmail.com

```
The keepcr flag is only used in the split_patches function, which is
only called before a patch application has to stopped for user input,
not after resuming. It is therefore unnecessary to persist the
flag. This seems to have been the case since it was introduced in
ad2c928 (git-am: Add command line parameter `--keep-cr` passing it to
git-mailsplit, 2010-02-27).

Signed-off-by: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
---
 git-am.sh |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/git-am.sh b/git-am.sh
index 9042432..1c13b13 100755
--- a/git-am.sh
+++ b/git-am.sh
@@ -530,7 +530,6 @@ else
 	echo "$sign" >"$dotest/sign"
 	echo "$utf8" >"$dotest/utf8"
 	echo "$keep" >"$dotest/keep"
-	echo "$keepcr" >"$dotest/keepcr"
 	echo "$scissors" >"$dotest/scissors"
 	echo "$no_inbody_headers" >"$dotest/no_inbody_headers"
 	echo "$GIT_QUIET" >"$dotest/quiet"
@@ -576,12 +575,6 @@ if test "$(cat "$dotest/keep")" = t
 then
 	keep=-k
 fi
-case "$(cat "$dotest/keepcr")" in
-t)
-	keepcr=--keep-cr ;;
-f)
-	keepcr=--no-keep-cr ;;
-esac
 case "$(cat "$dotest/scissors")" in
 t)
 	scissors=--scissors ;;
-- 
1.7.8.237.gcc4e3

```

## Junio C Hamano, 2011-12-09 18:50

Subject: Re: [PATCH] am: don't persist keepcr flag
Message-ID: <7v1usdebnf.fsf@alter.siamese.dyndns.org>
URL: https://gitlist.dev/e/7v1usdebnf.fsf%40alter.siamese.dyndns.org
In-Reply-To: <1323415845-11826-1-git-send-email-martin.von.zweigbergk@gmail.com>

```
Makes sense; thanks.

```