# [PATCH] compat/getpass.c: Fix a sparse "symbol not declared" warning 2 messages from 2011-11-30 to 2011-12-01. Participants: Ramsay Jones, Jeff King. Thread: https://gitlist.dev/t/29064 ## Ramsay Jones, 2011-11-30 20:54 Subject: [PATCH] compat/getpass.c: Fix a sparse "symbol not declared" warning Message-ID: <4ED69803.6070508@ramsay1.demon.co.uk> URL: https://gitlist.dev/e/4ED69803.6070508%40ramsay1.demon.co.uk ``` In particular, sparse complains as follows: SP compat/getpass.c compat/getpass.c:5:6: warning: symbol 'getpass_echo' was not \ declared. Should it be static? In order to suppress the warning, we include the getpass.h header file which contains an appropriate extern declaration. Signed-off-by: Ramsay Jones --- Hi Jeff, When you next re-roll your most recent credentials/getpass series, could you please squash this patch in. (This patch was against pu @ 1cc922af, but I guess you need to apply a similar patch to commit 8eca119c "stub out getpass_echo function", 27-11-2011 instead) Thanks! ATB, Ramsay Jones compat/getpass.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/compat/getpass.c b/compat/getpass.c index b5bd1dd..a145d27 100644 --- a/compat/getpass.c +++ b/compat/getpass.c @@ -1,4 +1,5 @@ #include "../git-compat-util.h" +#include "getpass.h" #ifdef HAVE_DEV_TTY -- 1.7.7 ``` ## Jeff King, 2011-12-01 18:19 Subject: Re: [PATCH] compat/getpass.c: Fix a sparse "symbol not declared" warning Message-ID: <20111201181957.GA29456@sigill.intra.peff.net> URL: https://gitlist.dev/e/20111201181957.GA29456%40sigill.intra.peff.net In-Reply-To: <4ED69803.6070508@ramsay1.demon.co.uk> ``` On Wed, Nov 30, 2011 at 08:54:27PM +0000, Ramsay Jones wrote: > When you next re-roll your most recent credentials/getpass series, could > you please squash this patch in. (This patch was against pu @ 1cc922af, > but I guess you need to apply a similar patch to commit 8eca119c "stub out > getpass_echo function", 27-11-2011 instead) Sure, makes sense. Thanks. -Peff ```