# [PATCH] Make feed title valid utf8

3 messages from 2011-11-27 to 2011-11-29. Participants: Jürgen Kreileder, Jakub Narebski, Junio C Hamano.
Thread: https://gitlist.dev/t/29030

## Jürgen Kreileder, 2011-11-27 22:37

Subject: [PATCH] Make feed title valid utf8
Message-ID: <CAKD0UuxFVtCRT+hqO5vkDRanaX3Gvwf9MAFqNUwAiFA+wEwxXg@mail.gmail.com>
URL: https://gitlist.dev/e/CAKD0UuxFVtCRT%2BhqO5vkDRanaX3Gvwf9MAFqNUwAiFA%2BwEwxXg%40mail.gmail.com

```
gitweb doesn't properly handle UTF8 site names when generating feed titles.

Signed-off-by: Juergen Kreileder <jk@blackdown.de>
---
 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 4f0c3bd..a2838c3 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -7482,7 +7482,7 @@ sub git_feed {
 	return if ($cgi->request_method() eq 'HEAD');

 	# header variables
-	my $title = "$site_name - $project/$action";
+	my $title = to_utf8($site_name) . " - " . to_utf8($project) . "/$action";
 	my $feed_type = 'log';
 	if (defined $hash) {
 		$title .= " - '$hash'";
-- 
1.7.5.4

```

## Jakub Narebski, 2011-11-29 19:48

Subject: Re: [PATCH] Make feed title valid utf8
Message-ID: <m38vmylnfu.fsf@localhost.localdomain>
URL: https://gitlist.dev/e/m38vmylnfu.fsf%40localhost.localdomain
In-Reply-To: <CAKD0UuxFVtCRT+hqO5vkDRanaX3Gvwf9MAFqNUwAiFA+wEwxXg@mail.gmail.com>

```
Subject: gitweb: Make feed title valid utf8

Jürgen Kreileder <jk@blackdown.de> writes:

> gitweb doesn't properly handle UTF8 site names when generating feed titles.
> 
> Signed-off-by: Juergen Kreileder <jk@blackdown.de>
> ---
>  gitweb/gitweb.perl |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 4f0c3bd..a2838c3 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -7482,7 +7482,7 @@ sub git_feed {
>  	return if ($cgi->request_method() eq 'HEAD');
> 
>  	# header variables
> -	my $title = "$site_name - $project/$action";
> +	my $title = to_utf8($site_name) . " - " . to_utf8($project) . "/$action";
>  	my $feed_type = 'log';
>  	if (defined $hash) {
>  		$title .= " - '$hash'";
> -- 

Thanks.  With the minor nit of prefixing subject with subsystem
designation, i.e. with "gitweb: " -- ACK.

-- 
Jakub Narębski

```

## Junio C Hamano, 2011-11-29 20:11

Subject: Re: [PATCH] Make feed title valid utf8
Message-ID: <7vfwh6sn7v.fsf@alter.siamese.dyndns.org>
URL: https://gitlist.dev/e/7vfwh6sn7v.fsf%40alter.siamese.dyndns.org
In-Reply-To: <m38vmylnfu.fsf@localhost.localdomain>

```
Thanks for patches and reviews.

I am not keeping track of what is acked unconditionally, what is acked
with reservation i.e. "with this tweak on top", and what is rejected with
suggestion of an alternative, though. I hope I can expect to see a series
that is finished between you two to be resent for application after 1.7.8
ships.

```