# [PATCH] revert: do not pass non-literal string as format to git_path()

2 messages from 2011-11-23 to 2011-11-23. Participants: Nguyễn Thái Ngọc Duy, Junio C Hamano.
Thread: https://gitlist.dev/t/29009

## Nguyễn Thái Ngọc Duy, 2011-11-23 12:45

Subject: [PATCH] revert: do not pass non-literal string as format to git_path()
Message-ID: <1322052336-13619-1-git-send-email-pclouds@gmail.com>
URL: https://gitlist.dev/e/1322052336-13619-1-git-send-email-pclouds%40gmail.com

```
This fixes the following warning.

    CC builtin/revert.o
builtin/revert.c: In function ‘write_cherry_pick_head’:
builtin/revert.c:311: warning: format not a string literal and no format arguments

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 builtin/revert.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/builtin/revert.c b/builtin/revert.c
index 0c61668..9b9b2e5 100644
--- a/builtin/revert.c
+++ b/builtin/revert.c
@@ -308,7 +308,7 @@ static void write_cherry_pick_head(struct commit *commit, const char *pseudoref)
 
 	strbuf_addf(&buf, "%s\n", sha1_to_hex(commit->object.sha1));
 
-	filename = git_path(pseudoref);
+	filename = git_path("%s", pseudoref);
 	fd = open(filename, O_WRONLY | O_CREAT, 0666);
 	if (fd < 0)
 		die_errno(_("Could not open '%s' for writing"), filename);
-- 
1.7.4.74.g639db

```

## Junio C Hamano, 2011-11-23 17:29

Subject: Re: [PATCH] revert: do not pass non-literal string as format to git_path()
Message-ID: <7vty5ubvde.fsf@alter.siamese.dyndns.org>
URL: https://gitlist.dev/e/7vty5ubvde.fsf%40alter.siamese.dyndns.org
In-Reply-To: <1322052336-13619-1-git-send-email-pclouds@gmail.com>

```
Thanks.

```