# [PATCH] convert.c: Fix return type of git_path_check_eol() 2 messages from 2011-11-21 to 2011-11-22. Participants: Ramsay Jones, Ramkumar Ramachandra. Thread: https://gitlist.dev/t/28995 ## Ramsay Jones, 2011-11-21 18:42 Subject: [PATCH] convert.c: Fix return type of git_path_check_eol() Message-ID: <4ECA9B81.9070101@ramsay1.demon.co.uk> URL: https://gitlist.dev/e/4ECA9B81.9070101%40ramsay1.demon.co.uk ``` The git_path_check_eol() function converts a string value to the corresponding 'enum eol' value. However, the function is currently declared to return an 'enum crlf_action', which causes sparse to complain thus: SP convert.c convert.c:736:50: warning: mixing different enum types convert.c:736:50: int enum crlf_action versus convert.c:736:50: int enum eol In order to suppress the warning, we simply correct the return type in the function declaration. Signed-off-by: Ramsay Jones --- convert.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/convert.c b/convert.c index 038b0be..86e9c29 100644 --- a/convert.c +++ b/convert.c @@ -658,7 +658,7 @@ static enum crlf_action git_path_check_crlf(const char *path, struct git_attr_ch return CRLF_GUESS; } -static enum crlf_action git_path_check_eol(const char *path, struct git_attr_check *check) +static enum eol git_path_check_eol(const char *path, struct git_attr_check *check) { const char *value = check->value; -- 1.7.7 ``` ## Ramkumar Ramachandra, 2011-11-22 02:03 Subject: Re: [PATCH] convert.c: Fix return type of git_path_check_eol() Message-ID: URL: https://gitlist.dev/e/CALkWK0%3DXMOivrQDkoCCBPNJ1JWnCJiGmDVmjGZHZz%2BX2C1P07A%40mail.gmail.com In-Reply-To: <4ECA9B81.9070101@ramsay1.demon.co.uk> ``` Hi Ramsay, Ramsay Jones wrote: > [...] > diff --git a/convert.c b/convert.c > index 038b0be..86e9c29 100644 > --- a/convert.c > +++ b/convert.c > @@ -658,7 +658,7 @@ static enum crlf_action git_path_check_crlf(const char *path, struct git_attr_ch >        return CRLF_GUESS; >  } > > -static enum crlf_action git_path_check_eol(const char *path, struct git_attr_check *check) > +static enum eol git_path_check_eol(const char *path, struct git_attr_check *check) >  { >        const char *value = check->value; > Looks good. Thanks. -- Ram ```