threads / patch / 28994

patchspec: add missing build dependency

Subject: [PATCH] spec: add missing build dependency

## tl;dr

2 messages between Nov 21, 2011 and Nov 21, 2011. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Felipe Contreras· Nov 21, 2011, 15:35 UTC · lore

From: Felipe Contreras <felipe.contreras@gmail.com>

Otherwise:

/usr/bin/perl Makefile.PL PREFIX='/opt/git' INSTALL_BASE='' Can't locate ExtUtils/MakeMaker.pm in @INC (@INC contains: /usr/local/lib/perl5 /usr/local/share/perl5 /usr/lib/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib/perl5 /usr/share/perl5 .) at Makefile.PL line 1. BEGIN failed--compilation aborted at Makefile.PL line 1. make[1]: *** [perl.mak] Error 2 make: *** [perl/perl.mak] Error 2

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 git.spec.in |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Show changes to git.spec.in +1 −0

diff --git a/git.spec.in b/git.spec.in
index c562c62..4d7ac1a 100644
--- a/git.spec.in
+++ b/git.spec.in
@@ -101,6 +101,7 @@ Group:          Development/Libraries
 Requires:       git = %{version}-%{release}
 Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
 BuildRequires:  perl(Error)
+BuildRequires:  perl(ExtUtils::MakeMaker)
 
 %description -n perl-Git
 Perl interface to Git

-- 
1.7.7.3

Felipe Contreras· Nov 21, 2011, 15:43 UTC · re: Felipe Contreras · lore

Re: [PATCH] spec: add missing build dependency

On Mon, Nov 21, 2011 at 5:35 PM, Felipe Contreras <felipe.contreras@nokia.com> wrote:

Show 9 quoted lines

> From: Felipe Contreras <felipe.contreras@gmail.com>
>
> Otherwise:
>
> /usr/bin/perl Makefile.PL PREFIX='/opt/git' INSTALL_BASE=''
> Can't locate ExtUtils/MakeMaker.pm in @INC (@INC contains: /usr/local/lib/perl5 /usr/local/share/perl5 /usr/lib/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib/perl5 /usr/share/perl5 .) at Makefile.PL line 1.
> BEGIN failed--compilation aborted at Makefile.PL line 1.
> make[1]: *** [perl.mak] Error 2
> make: *** [perl/perl.mak] Error 2

Just to clarify... I didn't actually build the RPM, just doing 'make install' after getting the dependencies from the spec. So I'm not sure if this is really needed.

-- 
Felipe Contreras