threads / patch / 28984

patch, 3 partst5501-*.sh: Fix url passed to clone in setup test

Subject: [PATCH 1/3] t5501-*.sh: Fix url passed to clone in setup test

## tl;dr

2 messages between Nov 19, 2011 and Nov 21, 2011. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Ramsay Jones· Nov 19, 2011, 19:38 UTC · lore

In particular, the url passed to git-clone has an extra '/' given after the 'file://' schema prefix, thus:

    git clone --reference=original "file:///$(pwd)/original one

Once the prefix is removed, the remainder of the url looks something like "//home/ramsay/git/t/...", which is then interpreted as an network path. This then results in a "Permission denied" error, like so:

    ramsay $ ls //home
    ls: cannot access //home: No such host or network path
    ramsay $ ls //home/ramsay
    ls: cannot access //home/ramsay: Permission denied
    ramsay $

In order to fix the problem, we simply remove the extraneous '/' character from the url.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
 t/t5501-fetch-push-alternates.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to t/t5501-fetch-push-alternates.sh +1 −1

diff --git a/t/t5501-fetch-push-alternates.sh b/t/t5501-fetch-push-alternates.sh
index b5ced84..1bc57ac 100755
--- a/t/t5501-fetch-push-alternates.sh
+++ b/t/t5501-fetch-push-alternates.sh
@@ -28,7 +28,7 @@ test_expect_success setup '
 		done
 	) &&
 	(
-		git clone --reference=original "file:///$(pwd)/original" one &&
+		git clone --reference=original "file://$(pwd)/original" one &&
 		cd one &&
 		echo Z >count &&
 		git add count &&

-- 
1.7.7

Junio C Hamano· Nov 21, 2011, 03:24 UTC · re: Ramsay Jones · lore

Re: [PATCH 1/3] t5501-*.sh: Fix url passed to clone in setup test

Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:

Show 21 quoted lines

> In particular, the url passed to git-clone has an extra '/' given
> after the 'file://' schema prefix, thus:
>
>     git clone --reference=original "file:///$(pwd)/original one
>
> Once the prefix is removed, the remainder of the url looks something
> like "//home/ramsay/git/t/...", which is then interpreted as an
> network path. This then results in a "Permission denied" error, like
> so:
>
>     ramsay $ ls //home
>     ls: cannot access //home: No such host or network path
>     ramsay $ ls //home/ramsay
>     ls: cannot access //home/ramsay: Permission denied
>     ramsay $
>
> In order to fix the problem, we simply remove the extraneous '/'
> character from the url.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> ---

Thanks; obviously correct.

Show 16 quoted lines

>  t/t5501-fetch-push-alternates.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/t/t5501-fetch-push-alternates.sh b/t/t5501-fetch-push-alternates.sh
> index b5ced84..1bc57ac 100755
> --- a/t/t5501-fetch-push-alternates.sh
> +++ b/t/t5501-fetch-push-alternates.sh
> @@ -28,7 +28,7 @@ test_expect_success setup '
>  		done
>  	) &&
>  	(
> -		git clone --reference=original "file:///$(pwd)/original" one &&
> +		git clone --reference=original "file://$(pwd)/original" one &&
>  		cd one &&
>  		echo Z >count &&
>  		git add count &&