# [PATCH] Avoid misleading success message on error 2 messages from 2005-12-21 to 2005-12-21. Participants: Johannes Schindelin, Junio C Hamano. Thread: https://gitlist.dev/t/2896 ## Johannes Schindelin, 2005-12-21 16:53 Subject: [PATCH] Avoid misleading success message on error Message-ID: URL: https://gitlist.dev/e/Pine.LNX.4.63.0512211752340.16125%40wbgn013.biozentrum.uni-wuerzburg.de ``` When a push fails (for example when the remote head does not fast forward to the desired ref) it is not correct to print "Everything up-to-date". Signed-off-by: Johannes Schindelin --- send-pack.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) 67819bb187daa5a976bc3d721d5c9f920f52e4ba diff --git a/send-pack.c b/send-pack.c index a41bbe5..5bc2f01 100644 --- a/send-pack.c +++ b/send-pack.c @@ -272,7 +272,7 @@ static int send_pack(int in, int out, in packet_flush(out); if (new_refs) pack_objects(out, remote_refs); - else + else if (ret == 0) fprintf(stderr, "Everything up-to-date\n"); close(out); return ret; -- 0.99.9.GIT ``` ## Junio C Hamano, 2005-12-21 20:47 Subject: Re: [PATCH] Avoid misleading success message on error Message-ID: <7vmziu6uug.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vmziu6uug.fsf%40assigned-by-dhcp.cox.net In-Reply-To: ``` Johannes Schindelin writes: > When a push fails (for example when the remote head does not fast forward > to the desired ref) it is not correct to print "Everything up-to-date". Thanks. ```