# [PATCH/RFC] Restore line limit option in post-receive-email 4 messages from 2011-11-11 to 2012-01-12. Participants: Cheng Leong, Junio C Hamano. Thread: https://gitlist.dev/t/28911 ## Cheng Leong, 2011-11-11 06:35 Subject: [PATCH/RFC] Restore line limit option in post-receive-email Message-ID: <1320993311-27112-1-git-send-email-leongc@alumni.rice.edu> URL: https://gitlist.dev/e/1320993311-27112-1-git-send-email-leongc%40alumni.rice.edu ``` The hooks.emailmaxlines config currently has no effect. Stop prep_for_email from clobbering the already-initialized maxlines variable in the contrib/hooks/post-receive-email example. Signed-off-by: Cheng Leong --- contrib/hooks/post-receive-email | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email index ba077c1..ac2e0ed 100755 --- a/contrib/hooks/post-receive-email +++ b/contrib/hooks/post-receive-email @@ -85,7 +85,6 @@ prep_for_email() oldrev=$(git rev-parse $1) newrev=$(git rev-parse $2) refname="$3" - maxlines=$4 # --- Interpret # 0000->1234 (create) -- 1.7.7.1.msysgit.0 ``` ## Junio C Hamano, 2011-11-11 06:56 Subject: Re: [PATCH/RFC] Restore line limit option in post-receive-email Message-ID: <7v4nybrvug.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7v4nybrvug.fsf%40alter.siamese.dyndns.org In-Reply-To: <1320993311-27112-1-git-send-email-leongc@alumni.rice.edu> ``` Cheng Leong writes: > The hooks.emailmaxlines config currently has no effect. Stop > prep_for_email from clobbering the already-initialized maxlines > variable in the contrib/hooks/post-receive-email example. > > Signed-off-by: Cheng Leong > --- > contrib/hooks/post-receive-email | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email > index ba077c1..ac2e0ed 100755 > --- a/contrib/hooks/post-receive-email > +++ b/contrib/hooks/post-receive-email > @@ -85,7 +85,6 @@ prep_for_email() > oldrev=$(git rev-parse $1) > newrev=$(git rev-parse $2) > refname="$3" > - maxlines=$4 > > # --- Interpret > # 0000->1234 (create) Umm, there is another place where $maxlines is used without merit. Shouldn't we do something like below as well? contrib/hooks/post-receive-email | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email index ba077c1..e27ca3c 100755 --- a/contrib/hooks/post-receive-email +++ b/contrib/hooks/post-receive-email @@ -743,6 +743,6 @@ else while read oldrev newrev refname do prep_for_email $oldrev $newrev $refname || continue - generate_email $maxlines | send_mail + generate_email | send_mail done fi ``` ## Cheng Leong, 2011-11-11 07:08 Subject: Re: [PATCH/RFC] Restore line limit option in post-receive-email Message-ID: URL: https://gitlist.dev/e/CACor6wGkDPSkA_G117YtnsQA7H_cROKKW69m-jW_rb2SrVWo1w%40mail.gmail.com In-Reply-To: <7v4nybrvug.fsf@alter.siamese.dyndns.org> ``` Junio C Hamano wrote: > Umm, there is another place where $maxlines is used without > merit. Shouldn't we do something like below as well? ... > -               generate_email $maxlines | send_mail > +               generate_email | send_mail Agree. $maxlines is harmless, but extraneous here. Would you like me to reroll a patch with both or is this a trivial fixup? Cheng ``` ## Cheng Leong, 2012-01-12 21:01 Subject: Re: [PATCH/RFC] Restore line limit option in post-receive-email Message-ID: URL: https://gitlist.dev/e/loom.20120112T215910-481%40post.gmane.org In-Reply-To: ``` > Would you like me to reroll a patch with both or is this a trivial fixup? Bump. What do I need to do to contribute this patch? Thanks, Cheng ```