threads / patch / 28905

patchmktree: fix a memory leak in write_tree()

Subject: [PATCH] mktree: fix a memory leak in write_tree()

## tl;dr

One message between Nov 10, 2011 and Nov 10, 2011. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Liu Yuan· Nov 10, 2011, 09:04 UTC · lore
From: Liu Yuan <tailai.ly@taobao.com>
We forget to call strbuf_release to release the buf memory.
Signed-off-by: Liu Yuan <tailai.ly@taobao.com>
---
 builtin/mktree.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Show changes to builtin/mktree.c +1 −0
diff --git a/builtin/mktree.c b/builtin/mktree.c
index 098395f..4ae1c41 100644
--- a/builtin/mktree.c
+++ b/builtin/mktree.c
@@ -60,6 +60,7 @@ static void write_tree(unsigned char *sha1)
 	}
 
 	write_sha1_file(buf.buf, buf.len, tree_type, sha1);
+	strbuf_release(&buf);
 }
 
 static const char *mktree_usage[] = {
-- 
1.7.6.1

← back to recent threads