# [PATCH] gqit: enable compiler warnings 2 messages from 2005-12-21 to 2005-12-21. Participants: Pavel Roskin, Marco Costalba. Thread: https://gitlist.dev/t/2888 ## Pavel Roskin, 2005-12-21 02:11 Subject: [PATCH] gqit: enable compiler warnings Message-ID: <1135131068.1183.6.camel@dv> URL: https://gitlist.dev/e/1135131068.1183.6.camel%40dv ``` The "-O2" flag should be separated from the threading support. Besides, it belongs to CCFLAGS (compile flags common to C and C++), not to CPPFLAGS (preprocessor flags). While at that, enable all warnings by -Wall, except those about non-virtual destructors, which are "inherited" from Qt. Portability is not affected since -O2 was already gcc-specific. Signed-off-by: Pavel Roskin diff --git a/SConstruct b/SConstruct index 55fd206..b0b5d0f 100644 --- a/SConstruct +++ b/SConstruct @@ -27,8 +27,10 @@ env['ENV']['HOME'] = os.environ['HOME'] installDir = env['HOME']+'/bin' +env.Append( CCFLAGS = ['-O2', '-Wall' ,'-Wno-non-virtual-dtor'] ) + ## Uncomment the following if you need threading support threading -env.Append( CPPFLAGS = ['-O2', '-DQT_THREAD_SUPPORT', '-D_REENTRANT', '-I/usr/include/qt3'] ) +env.Append( CPPFLAGS = ['-DQT_THREAD_SUPPORT', '-D_REENTRANT', '-I/usr/include/qt3'] ) if os.uname()[0] == "FreeBSD": env.Append(LINKFLAGS=["-pthread"]) -- Regards, Pavel Roskin ``` ## Marco Costalba, 2005-12-21 07:11 Subject: Re: [PATCH] gqit: enable compiler warnings Message-ID: <43A9003A.8010408@yahoo.it> URL: https://gitlist.dev/e/43A9003A.8010408%40yahoo.it In-Reply-To: <1135131068.1183.6.camel@dv> ``` Pavel Roskin wrote: > The "-O2" flag should be separated from the threading support. Besides, > it belongs to CCFLAGS (compile flags common to C and C++), not to > CPPFLAGS (preprocessor flags). While at that, enable all warnings by > -Wall, except those about non-virtual destructors, which are "inherited" > from Qt. Portability is not affected since -O2 was already > gcc-specific. > > Signed-off-by: Pavel Roskin > Thanks applied. ___________________________________ Yahoo! Messenger: chiamate gratuite in tutto il mondo http://it.messenger.yahoo.com ```