# [PATCH] remote: fix remote set-url usage 5 messages from 2011-11-07 to 2011-11-07. Participants: Felipe Contreras, Junio C Hamano, Jonathan Nieder. Thread: https://gitlist.dev/t/28865 ## Felipe Contreras, 2011-11-07 03:36 Subject: [PATCH] remote: fix remote set-url usage Message-ID: <1320637017-30863-1-git-send-email-felipe.contreras@gmail.com> URL: https://gitlist.dev/e/1320637017-30863-1-git-send-email-felipe.contreras%40gmail.com ``` Bad copy-paste. Otherwise the help would be for a different command: git remote set-url --help Signed-off-by: Felipe Contreras --- builtin/remote.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/builtin/remote.c b/builtin/remote.c index e1285be..2add79a 100644 --- a/builtin/remote.c +++ b/builtin/remote.c @@ -1427,7 +1427,7 @@ static int set_url(int argc, const char **argv) "delete URLs"), OPT_END() }; - argc = parse_options(argc, argv, NULL, options, builtin_remote_update_usage, + argc = parse_options(argc, argv, NULL, options, builtin_remote_seturl_usage, PARSE_OPT_KEEP_ARGV0); if (add_mode && delete_mode) -- 1.7.7 ``` ## Junio C Hamano, 2011-11-07 04:34 Subject: Re: [PATCH] remote: fix remote set-url usage Message-ID: <7vk47c4klf.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vk47c4klf.fsf%40alter.siamese.dyndns.org In-Reply-To: <1320637017-30863-1-git-send-email-felipe.contreras@gmail.com> ``` Good eyes; thanks. ``` ## Junio C Hamano, 2011-11-07 05:12 Subject: Re: [PATCH] remote: fix remote set-url usage Message-ID: <7vfwi04itx.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vfwi04itx.fsf%40alter.siamese.dyndns.org In-Reply-To: <1320637017-30863-1-git-send-email-felipe.contreras@gmail.com> ``` Felipe Contreras writes: > Bad copy-paste. > > Otherwise the help would be for a different command: > git remote set-url --help > > Signed-off-by: Felipe Contreras > --- Doesn't the same thing apply to set-branches? builtin/remote.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/builtin/remote.c b/builtin/remote.c index c4d17b5..06741ec 100644 --- a/builtin/remote.c +++ b/builtin/remote.c @@ -1336,7 +1336,7 @@ static int set_branches(int argc, const char **argv) builtin_remote_setbranches_usage, 0); if (argc == 0) { error("no remote specified"); - usage_with_options(builtin_remote_seturl_usage, options); + usage_with_options(builtin_remote_setbranches_usage, options); } argv[argc] = NULL; ``` ## Junio C Hamano, 2011-11-07 05:44 Subject: Re: [PATCH] remote: fix remote set-url usage Message-ID: <7v7h3c4hcn.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7v7h3c4hcn.fsf%40alter.siamese.dyndns.org In-Reply-To: <7vfwi04itx.fsf@alter.siamese.dyndns.org> ``` By the way, these two are low-impact fixes to relatively ancient problems, so while it is not urgent enough to include them to the upcoming 1.7.8 (the users lived with the bug long enough and survived), I do not see much problem to include them in it, either. ``` ## Jonathan Nieder, 2011-11-07 09:48 Subject: Re: [PATCH] remote: fix remote set-url usage Message-ID: <20111107094841.GE30641@elie.hsd1.il.comcast.net> URL: https://gitlist.dev/e/20111107094841.GE30641%40elie.hsd1.il.comcast.net In-Reply-To: <7vfwi04itx.fsf@alter.siamese.dyndns.org> ``` Junio C Hamano wrote: > --- a/builtin/remote.c > +++ b/builtin/remote.c > @@ -1336,7 +1336,7 @@ static int set_branches(int argc, const char **argv) > builtin_remote_setbranches_usage, 0); > if (argc == 0) { > error("no remote specified"); > - usage_with_options(builtin_remote_seturl_usage, options); > + usage_with_options(builtin_remote_setbranches_usage, options); Good eyes. Thanks for catching it. ```