threads / patch / 28856

patchIntroduce commit.verbose config option

Subject: [PATCH] Introduce commit.verbose config option

## tl;dr

3 messages between Nov 5, 2011 and Nov 6, 2011. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Fernando Vezzosi· Nov 5, 2011, 18:07 UTC · lore

Enabling commit.verbose will make git commit behave as if --verbose was passed on the command line.

Reviewed-by: Sverre Rabbelier <srabbelier@gmail.com>
Signed-off-by: Fernando Vezzosi <buccia@repnz.net>
---
 Documentation/config.txt |    3 +++
 builtin/commit.c         |    4 ++++
 2 files changed, 7 insertions(+), 0 deletions(-)

Show changes to 2 files +7 −0

Documentation/config.txt, builtin/commit.c

diff --git a/Documentation/config.txt b/Documentation/config.txt
index 5a841da..6826788 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt
@@ -832,6 +832,9 @@ commit.template::
 	"{tilde}/" is expanded to the value of `$HOME` and "{tilde}user/" to the
 	specified user's home directory.
 
+commit.verbose::
+	A boolean to enable verbose mode like the --verbose flag does.
+
 include::diff-config.txt[]
 
 difftool.<tool>.path::
diff --git a/builtin/commit.c b/builtin/commit.c
index c46f2d1..c2a1f3d 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -1331,6 +1331,10 @@ static int git_commit_config(const char *k, const char *v, void *cb)
 		include_status = git_config_bool(k, v);
 		return 0;
 	}
+	if (!strcmp(k, "commit.verbose")) {
+		verbose = git_config_bool(k, v);
+		return 0;
+	}
 
 	return git_status_config(k, v, s);
 }

-- 
1.7.7.1

Nguyen Thai Ngoc Duy· Nov 6, 2011, 02:51 UTC · re: Fernando Vezzosi · lore

Re: [PATCH] Introduce commit.verbose config option

On Sun, Nov 6, 2011 at 1:07 AM, Fernando Vezzosi <buccia@repnz.net> wrote:

> Enabling commit.verbose will make git commit behave as if --verbose was
> passed on the command line.

Is it necessary? If you want short command, you would use alias instead of typing "commit". Adding --verbose to the alias to make the command even shorter is straightforward.

-- 
Duy

SZEDER Gábor· Nov 6, 2011, 12:52 UTC · re: Fernando Vezzosi · lore

Re: [PATCH] Introduce commit.verbose config option

On Sat, Nov 05, 2011 at 07:07:35PM +0100, Fernando Vezzosi wrote:

Show 21 quoted lines

> Enabling commit.verbose will make git commit behave as if --verbose was
> passed on the command line.
> 
> Reviewed-by: Sverre Rabbelier <srabbelier@gmail.com>
> Signed-off-by: Fernando Vezzosi <buccia@repnz.net>
> ---
>  Documentation/config.txt |    3 +++
>  builtin/commit.c         |    4 ++++
>  2 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index 5a841da..6826788 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> @@ -832,6 +832,9 @@ commit.template::
>  	"{tilde}/" is expanded to the value of `$HOME` and "{tilde}user/" to the
>  	specified user's home directory.
>  
> +commit.verbose::
> +	A boolean to enable verbose mode like the --verbose flag does.
> +

I just tried out this patch, and found that setting commit.verbose to true also affects git commit's behavior when invoked from scripts where you can't pass --verbose to git commit. I.e. the diff to be committed is shown for git revert, interactive rebase's reword or squash commands, or during 'git rebase --continue' after resolving a conflict. I think this should be mentioned both in the commit message and in the documentation.

Anyway, I like this change because I have a somewhat convoluted and flaky combination of hooks and editor scripts to do the same, and now I can finally get rid of them.

Best, Gábor