threads / discuss / 28787

Unused (assigned but not read) option in diff_no_index

Subject: Unused (assigned but not read) option in diff_no_index

## tl;dr

One message between Oct 28, 2011 and Oct 28, 2011.

replies: 0people: 1as markdown or json

Piotr Krukowiecki· Oct 28, 2011, 15:08 UTC · lore
Hi,

I noticed that "options" variable in diff-no-index.c:diff_no_index() is modified when "-q" is passed but not used (not read) at all. So either it can be removed or it should be used. "-q" is not described in git-diff man page.

This code was introduced in 0569e9b8 "git diff": do not ignore index without --no-index" - it was moved from builtin-diff.c (where it was used) but the code was refactored so I can't say if it should still be.

$ grep -E -2 '\boptions\b' diff-no-index.c
	int i;
	int no_index = 0;
	unsigned options = 0;
	/* Were we asked to do --no-index explicitly? */
--
			i++;
		else if (!strcmp(argv[i], "-q")) {
			options |= DIFF_SILENT_ON_REMOVED;
			i++;
		}
-- 
Piotr Krukowiecki

← back to recent threads