# [PATCH] Fix 'Cloning into' message 4 messages from 2011-10-26 to 2011-10-27. Participants: Richard Hartmann, Junio C Hamano. Thread: https://gitlist.dev/t/28774 ## Richard Hartmann, 2011-10-26 17:05 Subject: [PATCH] Fix 'Cloning into' message Message-ID: <1319648748-9150-1-git-send-email-richih.mailinglist@gmail.com> URL: https://gitlist.dev/e/1319648748-9150-1-git-send-email-richih.mailinglist%40gmail.com ``` Without this patch, git clone foo . results in this: Cloning into .... done. With it: Cloning into '.'... done. --- builtin/clone.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/builtin/clone.c b/builtin/clone.c index 488f48e..efe8b6c 100644 --- a/builtin/clone.c +++ b/builtin/clone.c @@ -577,9 +577,9 @@ int cmd_clone(int argc, const char **argv, const char *prefix) if (0 <= option_verbosity) { if (option_bare) - printf(_("Cloning into bare repository %s...\n"), dir); + printf(_("Cloning into bare repository '%s'...\n"), dir); else - printf(_("Cloning into %s...\n"), dir); + printf(_("Cloning into '%s'...\n"), dir); } init_db(option_template, INIT_DB_QUIET); write_config(&option_config); -- 1.7.7 ``` ## Richard Hartmann, 2011-10-27 16:46 Subject: [PATCH] Fix 'Cloning into' message Message-ID: <1319734013-8956-1-git-send-email-richih.mailinglist@gmail.com> URL: https://gitlist.dev/e/1319734013-8956-1-git-send-email-richih.mailinglist%40gmail.com In-Reply-To: <1319648748-9150-1-git-send-email-richih.mailinglist@gmail.com> ``` Without this patch, git clone foo . results in this: Cloning into .... done. With it: Cloning into '.'... done. Signed-off-by: Richard Hartmann --- builtin/clone.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/builtin/clone.c b/builtin/clone.c index 488f48e..efe8b6c 100644 --- a/builtin/clone.c +++ b/builtin/clone.c @@ -577,9 +577,9 @@ int cmd_clone(int argc, const char **argv, const char *prefix) if (0 <= option_verbosity) { if (option_bare) - printf(_("Cloning into bare repository %s...\n"), dir); + printf(_("Cloning into bare repository '%s'...\n"), dir); else - printf(_("Cloning into %s...\n"), dir); + printf(_("Cloning into '%s'...\n"), dir); } init_db(option_template, INIT_DB_QUIET); write_config(&option_config); -- 1.7.7 ``` ## Junio C Hamano, 2011-10-27 17:39 Subject: Re: [PATCH] Fix 'Cloning into' message Message-ID: <7vvcraz64i.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vvcraz64i.fsf%40alter.siamese.dyndns.org In-Reply-To: <1319734013-8956-1-git-send-email-richih.mailinglist@gmail.com> ``` Richard Hartmann writes: > Without this patch, > > git clone foo . > > results in this: > > Cloning into .... > done. > > With it: > > Cloning into '.'... > done. > > Signed-off-by: Richard Hartmann We try to be consistent and many places do quote user supplied paths in pair of single quotes in human readable messages, and this is in line with that pattern. $ git clone foo "joey's foo" would result in Cloning into 'joey's foo'... but that is probably Ok ;-) Thanks. ``` ## Richard Hartmann, 2011-10-27 18:34 Subject: Re: [PATCH] Fix 'Cloning into' message Message-ID: URL: https://gitlist.dev/e/CAD77%2BgQWhatFyo22au-k_ygjohPJ_HhkNvNSgqzX1wRaoiWgBw%40mail.gmail.com In-Reply-To: <7vvcraz64i.fsf@alter.siamese.dyndns.org> ``` On Thu, Oct 27, 2011 at 19:39, Junio C Hamano wrote: > We try to be consistent and many places do quote user supplied paths in > pair of single quotes in human readable messages, and this is in line with > that pattern. Exactly. That is why I chose single quotes. Sorry for not including the signed-off the first time. >    $ git clone foo "joey's foo" In that case, the user has other problems ;) Richard ```