# [PATCH 2/2] credential-cache--daemon.c: unlink() a potentially stale unix socket 2 messages from 2011-10-22 to 2011-10-22. Participants: Ramsay Jones, Jeff King. Thread: https://gitlist.dev/t/28746 ## Ramsay Jones, 2011-10-22 17:25 Subject: [PATCH 2/2] credential-cache--daemon.c: unlink() a potentially stale unix socket Message-ID: <4EA2FCA0.70002@ramsay1.demon.co.uk> URL: https://gitlist.dev/e/4EA2FCA0.70002%40ramsay1.demon.co.uk ``` Signed-off-by: Ramsay Jones --- credential-cache--daemon.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/credential-cache--daemon.c b/credential-cache--daemon.c index ee2c15a..c5fb1b2 100644 --- a/credential-cache--daemon.c +++ b/credential-cache--daemon.c @@ -230,6 +230,7 @@ static void serve_cache(const char *socket_path) { int fd; + unlink(socket_path); fd = unix_stream_listen(socket_path); if (fd < 0) die_errno("unable to bind to '%s'", socket_path); -- 1.7.7 ``` ## Jeff King, 2011-10-22 19:19 Subject: Re: [PATCH 2/2] credential-cache--daemon.c: unlink() a potentially stale unix socket Message-ID: <20111022191905.GD1785@sigill.intra.peff.net> URL: https://gitlist.dev/e/20111022191905.GD1785%40sigill.intra.peff.net In-Reply-To: <4EA2FCA0.70002@ramsay1.demon.co.uk> ``` On Sat, Oct 22, 2011 at 06:25:52PM +0100, Ramsay Jones wrote: > diff --git a/credential-cache--daemon.c b/credential-cache--daemon.c > index ee2c15a..c5fb1b2 100644 > --- a/credential-cache--daemon.c > +++ b/credential-cache--daemon.c > @@ -230,6 +230,7 @@ static void serve_cache(const char *socket_path) > { > int fd; > > + unlink(socket_path); > fd = unix_stream_listen(socket_path); > if (fd < 0) > die_errno("unable to bind to '%s'", socket_path); I think this is a sane thing to do, if it's more portable. We can just get rid of the double-bind attempt in unix_stream_listen, now. I suspect this unlink should probably just go directly into unix_stream_listen, too. -Peff ```