threads / patch / 28729

patchgit-gui: span widgets over the full file output area in the blame view

Subject: [PATCH] git-gui: span widgets over the full file output area in the blame view

## tl;dr

2 messages between Oct 20, 2011 and Oct 21, 2011. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Bert Wesarg· Oct 20, 2011, 19:30 UTC · lore
Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com>
---
 lib/blame.tcl |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)
Show changes to lib/blame.tcl +6 −3
diff --git a/lib/blame.tcl b/lib/blame.tcl
index 49eae19..b031e66 100644
--- a/lib/blame.tcl
+++ b/lib/blame.tcl
@@ -219,7 +219,8 @@ constructor new {i_commit i_path i_jump} {
 	eval grid $w_columns $w.file_pane.out.sby -sticky nsew
 	grid conf \
 		$w.file_pane.out.sbx \
-		-column [expr {[llength $w_columns] - 1}] \
+		-column 0 \
+		-columnspan [expr {[llength $w_columns] + 1}] \
 		-sticky we
 	grid columnconfigure \
 		$w.file_pane.out \
@@ -229,12 +230,14 @@ constructor new {i_commit i_path i_jump} {
 
 	set finder [::searchbar::new \
 		$w.file_pane.out.ff $w_file \
-		-column [expr {[llength $w_columns] - 1}] \
+		-column 0 \
+		-columnspan [expr {[llength $w_columns] + 1}] \
 		]
 
 	set gotoline [::linebar::new \
 		$w.file_pane.out.lf $w_file \
-		-column [expr {[llength $w_columns] - 1}] \
+		-column 0 \
+		-columnspan [expr {[llength $w_columns] + 1}] \
 		]
 
 	set w_cviewer $w.file_pane.cm.t
-- 
1.7.7.759.gfc8c6
Pat Thoyts· Oct 21, 2011, 21:41 UTC · re: Bert Wesarg · lore

Re: [PATCH] git-gui: span widgets over the full file output area in the blame view

Bert Wesarg <bert.wesarg@googlemail.com> writes:
Show 36 quoted lines
>Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com>
>---
> lib/blame.tcl |    9 ++++++---
> 1 files changed, 6 insertions(+), 3 deletions(-)
>
>diff --git a/lib/blame.tcl b/lib/blame.tcl
>index 49eae19..b031e66 100644
>--- a/lib/blame.tcl
>+++ b/lib/blame.tcl
>@@ -219,7 +219,8 @@ constructor new {i_commit i_path i_jump} {
> 	eval grid $w_columns $w.file_pane.out.sby -sticky nsew
> 	grid conf \
> 		$w.file_pane.out.sbx \
>-		-column [expr {[llength $w_columns] - 1}] \
>+		-column 0 \
>+		-columnspan [expr {[llength $w_columns] + 1}] \
> 		-sticky we
> 	grid columnconfigure \
> 		$w.file_pane.out \
>@@ -229,12 +230,14 @@ constructor new {i_commit i_path i_jump} {
> 
> 	set finder [::searchbar::new \
> 		$w.file_pane.out.ff $w_file \
>-		-column [expr {[llength $w_columns] - 1}] \
>+		-column 0 \
>+		-columnspan [expr {[llength $w_columns] + 1}] \
> 		]
> 
> 	set gotoline [::linebar::new \
> 		$w.file_pane.out.lf $w_file \
>-		-column [expr {[llength $w_columns] - 1}] \
>+		-column 0 \
>+		-columnspan [expr {[llength $w_columns] + 1}] \
> 		]
> 
> 	set w_cviewer $w.file_pane.cm.t
Looks good. Applied.
-- 
Pat Thoyts                            http://www.patthoyts.tk/
PGP fingerprint 2C 6E 98 07 2C 59 C8 97  10 CE 11 E6 04 E0 B9 DD

← back to recent threads