threads / patch / 28727

patchgit-remote-mediawiki: don't include HTTP login/password in author

Subject: [PATCH] git-remote-mediawiki: don't include HTTP login/password in author

## tl;dr

One message between Oct 20, 2011 and Oct 20, 2011. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Matthieu Moy· Oct 20, 2011, 17:04 UTC · lore

On the MediaWiki side, the author information is just the MediaWiki login of the contributor. The import turns it into login@$wiki_name to create the author's email address on the wiki side. But we don't want this to include the HTTP password if it's present in the URL ...

Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
---
 contrib/mw-to-git/git-remote-mediawiki |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
Show changes to contrib/mw-to-git/git-remote-mediawiki +4 −0
diff --git a/contrib/mw-to-git/git-remote-mediawiki b/contrib/mw-to-git/git-remote-mediawiki
index 0b32d18..c18bfa1 100755
--- a/contrib/mw-to-git/git-remote-mediawiki
+++ b/contrib/mw-to-git/git-remote-mediawiki
@@ -109,6 +109,10 @@ $dumb_push = ($dumb_push eq "true");
 
 my $wiki_name = $url;
 $wiki_name =~ s/[^\/]*:\/\///;
+# If URL is like http://user:password@example.com/, we clearly don't
+# want the password in $wiki_name. While we're there, also remove user
+# and '@' sign, to avoid author like MWUser@HTTPUser@host.com
+$wiki_name =~ s/^.*@//;
 
 # Commands parser
 my $entry;
-- 
1.7.7.140.ge3099

← back to recent threads