# [PATCH] Git-p4: Add "git p4 change" command. 2 messages from 2011-10-17 to 2011-10-17. Participants: Andrei Warkentin. Thread: https://gitlist.dev/t/28705 ## Andrei Warkentin, 2011-10-17 22:16 Subject: [PATCH] Git-p4: Add "git p4 change" command. Message-ID: <1318889798-17334-1-git-send-email-andreiw@vmware.com> URL: https://gitlist.dev/e/1318889798-17334-1-git-send-email-andreiw%40vmware.com ``` Many users of p4/sd use changelists for review, regression tests and batch builds. "p4 change" is almost equivalent to "p4 submit", yet will just create the changelist and not submit it. Signed-off-by: Andrei Warkentin --- contrib/fast-import/git-p4 | 16 ++++++++++++---- contrib/fast-import/git-p4.txt | 10 ++++++++++ 2 files changed, 22 insertions(+), 4 deletions(-) diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4 index 2f7b270..19c295b 100755 --- a/contrib/fast-import/git-p4 +++ b/contrib/fast-import/git-p4 @@ -959,7 +959,10 @@ class P4Submit(Command, P4UserMap): submitTemplate = message[:message.index(separatorLine)] if self.isWindows: submitTemplate = submitTemplate.replace("\r\n", "\n") - p4_write_pipe("submit -i", submitTemplate) + if gitConfig("git-p4.changeOnSubmit"): + p4_write_pipe("change -i", submitTemplate) + else: + p4_write_pipe("subadasdmit -i", submitTemplate) if self.preserveUser: if p4User: @@ -981,9 +984,14 @@ class P4Submit(Command, P4UserMap): file = open(fileName, "w+") file.write(self.prepareLogMessage(template, logMessage)) file.close() - print ("Perforce submit template written as %s. " - + "Please review/edit and then use p4 submit -i < %s to submit directly!" - % (fileName, fileName)) + if gitConfig("git-p4.changeOnSubmit"): + print ("Perforce submit template written as %s. " + + "Please review/edit and then use p4 change -i < %s to create changelist!" + % (fileName, fileName)) + else: + print ("Perforce submit template written as %s. " + + "Please review/edit and then use p4 submit -i < %s to submit directly!" + % (fileName, fileName)) def run(self, args): if len(args) == 0: diff --git a/contrib/fast-import/git-p4.txt b/contrib/fast-import/git-p4.txt index 52003ae..3a3a815 100644 --- a/contrib/fast-import/git-p4.txt +++ b/contrib/fast-import/git-p4.txt @@ -180,6 +180,16 @@ git-p4.allowSubmit git config [--global] git-p4.allowSubmit false +git-p4.changeOnSubmit + + git config [--global] git-p4.changeOnSubmit false + +Most places using p4/sourcedepot don't actually want you submit +changes directly, and changelists are used to do regression testing, +batch builds and review, hence, by setting this parameter to +true you acknowledge you end up creating a changelist which you +must then manually commit. + git-p4.syncFromOrigin A useful setup may be that you have a periodically updated git repository -- 1.7.4.1 ``` ## Andrei Warkentin, 2011-10-17 22:20 Subject: Re: [PATCH] Git-p4: Add "git p4 change" command. Message-ID: <682349072.26755.1318890034730.JavaMail.root@zimbra-prod-mbox-2.vmware.com> URL: https://gitlist.dev/e/682349072.26755.1318890034730.JavaMail.root%40zimbra-prod-mbox-2.vmware.com In-Reply-To: <1318889798-17334-1-git-send-email-andreiw@vmware.com> ``` ----- Original Message ----- > From: "Andrei Warkentin" > To: git@vger.kernel.org, gitster@pobox.com > Cc: "Andrei Warkentin" > Sent: Monday, October 17, 2011 6:16:38 PM > Subject: [PATCH] Git-p4: Add "git p4 change" command. > > Many users of p4/sd use changelists for review, regression > tests and batch builds. > > "p4 change" is almost equivalent to "p4 submit", yet will > just create the changelist and not submit it. > > Signed-off-by: Andrei Warkentin > --- Sorry for the spam, this is the wrong patch :-(. A ```