# [PATCH] send-email: Honour SMTP domain when using TLS

3 messages from 2011-10-15 to 2011-10-16. Participants: Matthew Daley, Junio C Hamano, Brian Gernhardt.
Thread: https://gitlist.dev/t/28686

## Matthew Daley, 2011-10-15 08:44

Subject: [PATCH] send-email: Honour SMTP domain when using TLS
Message-ID: <1318668292-13818-1-git-send-email-mattjd@gmail.com>
URL: https://gitlist.dev/e/1318668292-13818-1-git-send-email-mattjd%40gmail.com

```
git-send-email sends two SMTP EHLOs when using TLS encryption, however
only the first, unencrypted EHLO uses the SMTP domain that can be
optionally specified by the user (--smtp-domain).  This is because the
call to hello() that produces the second, encrypted EHLO does not pass
the SMTP domain as an argument, and hence a default of
'localhost.localdomain' is used instead.

Fix by passing in the SMTP domain in this call.

Signed-off-by: Matthew Daley <mattjd@gmail.com>
---
 git-send-email.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-send-email.perl b/git-send-email.perl
index 6885dfa..d491db9 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -1098,7 +1098,7 @@ X-Mailer: git-send-email $gitversion
 					$smtp_encryption = '';
 					# Send EHLO again to receive fresh
 					# supported commands
-					$smtp->hello();
+					$smtp->hello($smtp_domain);
 				} else {
 					die "Server does not support STARTTLS! ".$smtp->message;
 				}
-- 
1.7.2.5

```

## Junio C Hamano, 2011-10-16 03:36

Subject: Re: [PATCH] send-email: Honour SMTP domain when using TLS
Message-ID: <7v62jpvc8f.fsf@alter.siamese.dyndns.org>
URL: https://gitlist.dev/e/7v62jpvc8f.fsf%40alter.siamese.dyndns.org
In-Reply-To: <1318668292-13818-1-git-send-email-mattjd@gmail.com>

```
Matthew Daley <mattjd@gmail.com> writes:

> git-send-email sends two SMTP EHLOs when using TLS encryption, however
> only the first, unencrypted EHLO uses the SMTP domain that can be
> optionally specified by the user (--smtp-domain).  This is because the
> call to hello() that produces the second, encrypted EHLO does not pass
> the SMTP domain as an argument, and hence a default of
> 'localhost.localdomain' is used instead.
>
> Fix by passing in the SMTP domain in this call.
>
> Signed-off-by: Matthew Daley <mattjd@gmail.com>

Sounds sensible, thanks.

Brian, who did 69cf7bf (send-email: Cleanup smtp-domain and add config,
2010-04-10) to make the initial hello use $smtp_domain, could you take a
quick look and an Ack?

>  git-send-email.perl |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/git-send-email.perl b/git-send-email.perl
> index 6885dfa..d491db9 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -1098,7 +1098,7 @@ X-Mailer: git-send-email $gitversion
>  					$smtp_encryption = '';
>  					# Send EHLO again to receive fresh
>  					# supported commands
> -					$smtp->hello();
> +					$smtp->hello($smtp_domain);
>  				} else {
>  					die "Server does not support STARTTLS! ".$smtp->message;
>  				}

```

## Brian Gernhardt, 2011-10-16 04:18

Subject: Re: [PATCH] send-email: Honour SMTP domain when using TLS
Message-ID: <B691D22B-2FB3-407B-A986-EECB97ED29B0@gernhardtsoftware.com>
URL: https://gitlist.dev/e/B691D22B-2FB3-407B-A986-EECB97ED29B0%40gernhardtsoftware.com
In-Reply-To: <7v62jpvc8f.fsf@alter.siamese.dyndns.org>

```

On Oct 15, 2011, at 11:36 PM, Junio C Hamano wrote:

> Matthew Daley <mattjd@gmail.com> writes:
> 
>> git-send-email sends two SMTP EHLOs when using TLS encryption, however
>> only the first, unencrypted EHLO uses the SMTP domain that can be
>> optionally specified by the user (--smtp-domain).  This is because the
>> call to hello() that produces the second, encrypted EHLO does not pass
>> the SMTP domain as an argument, and hence a default of
>> 'localhost.localdomain' is used instead.
>> 
>> Fix by passing in the SMTP domain in this call.
>> 
>> Signed-off-by: Matthew Daley <mattjd@gmail.com>
> 
> Sounds sensible, thanks.
> 
> Brian, who did 69cf7bf (send-email: Cleanup smtp-domain and add config,
> 2010-04-10) to make the initial hello use $smtp_domain, could you take a
> quick look and an Ack?

It does look sensible to me, but I wasn't the one who added all the HELO work.  I mostly was mucking about with variable names and how they got set.  Jari Aalto added them originally in 134550f.

~~ Brian
```