# [PATCH] strbuf.c: remove unnecessary strbuf_grow() from strbuf_getwholeline()

1 messages from 2011-10-06 to 2011-10-06. Participants: Brandon Casey.
Thread: https://gitlist.dev/t/28600

## Brandon Casey, 2011-10-06 04:21

Subject: [PATCH] strbuf.c: remove unnecessary strbuf_grow() from strbuf_getwholeline()
Message-ID: <1317874893-4167-1-git-send-email-drafnel@gmail.com>
URL: https://gitlist.dev/e/1317874893-4167-1-git-send-email-drafnel%40gmail.com

```
This use of strbuf_grow() is a historical artifact that was once used to
ensure that strbuf.buf was allocated and properly nul-terminated.  This
was added before the introduction of the slopbuf in b315c5c0, which
guarantees that strbuf.buf always points to a usable nul-terminated string.
So let's remove it.

Signed-off-by: Brandon Casey <drafnel@gmail.com>
---
 strbuf.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/strbuf.c b/strbuf.c
index 9ff1b59..3ad2cc0 100644
--- a/strbuf.c
+++ b/strbuf.c
@@ -357,7 +357,6 @@ int strbuf_getwholeline(struct strbuf *sb, FILE *fp, int term)
 {
 	int ch;
 
-	strbuf_grow(sb, 0);
 	if (feof(fp))
 		return EOF;
 
-- 
1.7.7.1.ge3b6f

```