threads / patch / 2857

patch, 3 partsUsage string clean-up (diff, log and whatchanged)

Subject: [PATCH 0/3] Usage string clean-up (diff, log and whatchanged)

## tl;dr

4 messages between Dec 15, 2005 and Dec 15, 2005. Diffs are folded; open one to read it.

replies: 3people: 1as markdown or json

Fredrik Kuivinen· Dec 15, 2005, 22:43 UTC · lore

Hi,

Apparently I forgot those commands in the previous patch series.

 git-diff.sh        |   14 ++++++--------
 git-log.sh         |    8 ++++----
 git-whatchanged.sh |    5 +++++
 3 files changed, 15 insertions(+), 12 deletions(-)

- Fredrik

Fredrik Kuivinen· Dec 15, 2005, 22:47 UTC · re: Fredrik Kuivinen · lore

[PATCH 1/3] git-diff: Usage string clean-up

Signed-off-by: Fredrik Kuivinen <freku045@student.liu.se>

---

 git-diff.sh |   14 ++++++--------
 1 files changed, 6 insertions(+), 8 deletions(-)

ca73d87d08c8c3702495694cc1080112c4c34ba1

Show changes to git-diff.sh +6 −8

diff --git a/git-diff.sh b/git-diff.sh
index b62e583..4812ae4 100755
--- a/git-diff.sh
+++ b/git-diff.sh
@@ -3,15 +3,14 @@
 # Copyright (c) 2005 Linus Torvalds
 # Copyright (c) 2005 Junio C Hamano
 
+USAGE='[ --diff-options ] <ent>{0,2} [<path>...]'
+SUBDIRECTORY_OK='Yes'
+. git-sh-setup
+
 rev=$(git-rev-parse --revs-only --no-flags --sq "$@") || exit
 flags=$(git-rev-parse --no-revs --flags --sq "$@")
 files=$(git-rev-parse --no-revs --no-flags --sq "$@")
 
-die () {
-    echo >&2 "$*"
-    exit 1
-}
-
 # I often say 'git diff --cached -p' and get scolded by git-diff-files, but
 # obviously I mean 'git diff --cached -p HEAD' in that case.
 case "$rev" in
@@ -40,8 +39,7 @@ esac
 
 case "$rev" in
 ?*' '?*' '?*)
-	echo >&2 "I don't understand"
-	exit 1
+	usage
 	;;
 ?*' '^?*)
 	begin=$(expr "$rev" : '.*^.\([0-9a-f]*\).*') &&
@@ -58,7 +56,7 @@ case "$rev" in
 	cmd="git-diff-files $flags -- $files"
 	;;
 *)
-	die "I don't understand $*"
+	usage
 	;;
 esac

-- 
0.99.9.GIT

Fredrik Kuivinen· Dec 15, 2005, 22:48 UTC · re: Fredrik Kuivinen · lore

[PATCH 2/3] git-log: Add usage string

Signed-off-by: Fredrik Kuivinen <freku045@student.liu.se>

---

 git-log.sh |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

381a6c62ad8e735de6122127c7684e8a14f41676

Show changes to git-log.sh +4 −4

diff --git a/git-log.sh b/git-log.sh
index b36c4e9..c2ea71c 100755
--- a/git-log.sh
+++ b/git-log.sh
@@ -3,13 +3,13 @@
 # Copyright (c) 2005 Linus Torvalds
 #
 
-# This one uses only subdirectory-aware commands, so no need to
-# include sh-setup-script.
+USAGE='[--max-count=<n>] [<since>..<limit>] [--pretty=<format>] [git-rev-list options]'
+SUBDIRECTORY_OK='Yes'
+. git-sh-setup
 
 revs=$(git-rev-parse --revs-only --no-flags --default HEAD "$@") || exit
 [ "$revs" ] || {
-	echo >&2 "No HEAD ref"
-	exit 1
+	die "No HEAD ref"
 }
 git-rev-list --pretty $(git-rev-parse --default HEAD "$@") |
 LESS=-S ${PAGER:-less}

-- 
0.99.9.GIT

Fredrik Kuivinen· Dec 15, 2005, 22:48 UTC · re: Fredrik Kuivinen · lore

[PATCH 3/3] git-whatchanged: Add usage string

Signed-off-by: Fredrik Kuivinen <freku045@student.liu.se>

---

 git-whatchanged.sh |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

1d3bc689dd66918b27432ad868592c9cc557f926

Show changes to git-whatchanged.sh +5 −0

diff --git a/git-whatchanged.sh b/git-whatchanged.sh
index 85a49fc..b170f74 100755
--- a/git-whatchanged.sh
+++ b/git-whatchanged.sh
@@ -1,4 +1,9 @@
 #!/bin/sh
+
+USAGE='[-p] [--max-count=<n>] [<since>..<limit>] [--pretty=<format>] [-m] [git-diff-tree options] [git-rev-list options]'
+SUBDIRECTORY_OK='Yes'
+. git-sh-setup
+
 rev_list_args=$(git-rev-parse --sq --default HEAD --revs-only "$@") &&
 diff_tree_args=$(git-rev-parse --sq --no-revs "$@") &&

-- 
0.99.9.GIT