# [PATCH] SubmittingPathces: remove Cogito reference 2 messages from 2011-09-11 to 2011-09-12. Participants: Sverre Rabbelier, Ramkumar Ramachandra. Thread: https://gitlist.dev/t/28356 ## Sverre Rabbelier, 2011-09-11 12:38 Subject: [PATCH] SubmittingPathces: remove Cogito reference Message-ID: <1315744690-6477-1-git-send-email-srabbelier@gmail.com> URL: https://gitlist.dev/e/1315744690-6477-1-git-send-email-srabbelier%40gmail.com ``` Removing Cogito leaves just git and StGit, which is a rather incomplete list of git diff tools available. Sidestep the problem of deciding what tools to mention by not mentioning any. Signed-off-by: Sverre Rabbelier --- Reading `git log -p --reverse Documentation/SubmittingPatches` [0] I noticed the Cogito reference was never removed. In the light of the recent discussion about removing Cogito from the GitSurvey I figured now might be a good time to remove this reference as well. [0] https://plus.google.com/115991361267198418069/posts/NPa7vQYeMnm Documentation/SubmittingPatches | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 938eccf..0dbf2c9 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -134,8 +134,7 @@ Another thing: NULL pointers shall be written as NULL, not as 0. (2) Generate your patch using git tools out of your commits. -git based diff tools (git, Cogito, and StGIT included) generate -unidiff which is the preferred format. +git based diff tools generate unidiff which is the preferred format. You do not have to be afraid to use -M option to "git diff" or "git format-patch", if your patch involves file renames. The -- 1.7.6.1.724.g9519c ``` ## Ramkumar Ramachandra, 2011-09-12 05:25 Subject: Re: [PATCH] SubmittingPathces: remove Cogito reference Message-ID: URL: https://gitlist.dev/e/CALkWK0mqnTN8GYZ%3DA5Oz9hfEYshbFUxD%2B895XsCaxXkDMAFuKQ%40mail.gmail.com In-Reply-To: <1315744690-6477-1-git-send-email-srabbelier@gmail.com> ``` Hi Sverre, Sverre Rabbelier writes: > Subject: [PATCH] SubmittingPathces: remove Cogito reference You misspelled SubmittingPatches there. Also, I feel that the subject is a little misleading. Perhaps something like this instead? SubmittingPatches: Remove diff tool examples > [...] Looks alright otherwise. Thanks. -- Ram ```