threads / patch / 28258

patchSymlink mergetools scriptlets into valgrind wrappers

Subject: [PATCH] Symlink mergetools scriptlets into valgrind wrappers

## tl;dr

3 messages between Aug 30, 2011 and Aug 30, 2011. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Thomas Rast· Aug 30, 2011, 00:47 UTC · lore

Since bc7a96a (mergetool--lib: Refactor tools into separate files, 2011-08-18) the mergetools and difftools related tests fail under --valgrind because the mergetools/* scriptlets are not in the exec path.

For now, symlink the mergetools subdir into the t/valgrind/bin directory as a whole, since it does not contain anything of interest to the valgrind wrappers.

Signed-off-by: Thomas Rast <trast@student.ethz.ch>
---
 t/test-lib.sh |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Show changes to t/test-lib.sh +2 −0
diff --git a/t/test-lib.sh b/t/test-lib.sh
index d7dfc8b..bdd9513 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -950,6 +950,8 @@ then
 	do
 		make_valgrind_symlink $file
 	done
+	# special-case the mergetools loadables
+	make_symlink "$GIT_BUILD_DIR"/mergetools "$GIT_VALGRIND/bin/mergetools"
 	OLDIFS=$IFS
 	IFS=:
 	for path in $PATH

-- 
1.7.7.rc0.370.gdcae57
Jeff King· Aug 30, 2011, 18:16 UTC · re: Thomas Rast · lore

Re: [PATCH] Symlink mergetools scriptlets into valgrind wrappers

On Tue, Aug 30, 2011 at 02:47:36AM +0200, Thomas Rast wrote:
Show 8 quoted lines
> Since bc7a96a (mergetool--lib: Refactor tools into separate files,
> 2011-08-18) the mergetools and difftools related tests fail under
> --valgrind because the mergetools/* scriptlets are not in the exec
> path.
> 
> For now, symlink the mergetools subdir into the t/valgrind/bin
> directory as a whole, since it does not contain anything of interest
> to the valgrind wrappers.

I'm not super-excited about special-casing like this, but I don't think there's a way to make it much cleaner without a lot of fuss. And the valgrind stuff is pretty special-cased as it is (it would probably be cleaner if it were integrated with the bin-wrappers rules in the Makefile). But it's probably not worth spending effort on it. What's there works, and your patch is a sane and straightforward fix for this new issue. So:

Acked-by: Jeff King <peff@peff.net>
-Peff

← back to recent threads