# [PATCH] Skip archive --remote tests on Windows 3 messages from 2011-08-03 to 2011-08-03. Participants: Johannes Sixt, Jakub Narebski. Thread: https://gitlist.dev/t/28005 ## Johannes Sixt, 2011-08-03 08:20 Subject: [PATCH] Skip archive --remote tests on Windows Message-ID: <4E3904B8.7080208@viscovery.net> URL: https://gitlist.dev/e/4E3904B8.7080208%40viscovery.net ``` From: Johannes Sixt These depend on a working git-upload-archive, which is broken on Windows, because it depends on fork(). Signed-off-by: Johannes Sixt --- These prerequisites are needed in current master, but would have to be patched out again by Erik's upload-archive series. t/t5000-tar-tree.sh | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/t/t5000-tar-tree.sh b/t/t5000-tar-tree.sh index 9e3ba98..d906898 100755 --- a/t/t5000-tar-tree.sh +++ b/t/t5000-tar-tree.sh @@ -266,7 +266,7 @@ test_expect_success 'archive --list mentions user filter' ' grep "^bar\$" output ' -test_expect_success 'archive --list shows only enabled remote filters' ' +test_expect_success NOT_MINGW 'archive --list shows only enabled remote filters' ' git archive --list --remote=. >output && ! grep "^tar\.foo\$" output && grep "^bar\$" output @@ -298,7 +298,7 @@ test_expect_success 'extension matching requires dot' ' test_cmp b.tar config-implicittar.foo ' -test_expect_success 'only enabled filters are available remotely' ' +test_expect_success NOT_MINGW 'only enabled filters are available remotely' ' test_must_fail git archive --remote=. --format=tar.foo HEAD \ >remote.tar.foo && git archive --remote=. --format=bar >remote.bar HEAD && @@ -341,12 +341,12 @@ test_expect_success GZIP,GUNZIP 'extract tgz file' ' test_cmp b.tar j.tar ' -test_expect_success GZIP 'remote tar.gz is allowed by default' ' +test_expect_success GZIP,NOT_MINGW 'remote tar.gz is allowed by default' ' git archive --remote=. --format=tar.gz HEAD >remote.tar.gz && test_cmp j.tgz remote.tar.gz ' -test_expect_success GZIP 'remote tar.gz can be disabled' ' +test_expect_success GZIP,NOT_MINGW 'remote tar.gz can be disabled' ' git config tar.tar.gz.remote false && test_must_fail git archive --remote=. --format=tar.gz HEAD \ >remote.tar.gz -- 1.7.6.1572.g1f80c3 ``` ## Jakub Narebski, 2011-08-03 09:09 Subject: Re: [PATCH] Skip archive --remote tests on Windows Message-ID: URL: https://gitlist.dev/e/m3hb5yrhfw.fsf%40localhost.localdomain In-Reply-To: <4E3904B8.7080208@viscovery.net> ``` Johannes Sixt writes: > From: Johannes Sixt > > These depend on a working git-upload-archive, which is broken on Windows, > because it depends on fork(). > > Signed-off-by: Johannes Sixt > --- > These prerequisites are needed in current master, but would have to be > patched out again by Erik's upload-archive series. [...] > -test_expect_success 'archive --list shows only enabled remote filters' ' > +test_expect_success NOT_MINGW 'archive --list shows only enabled remote filters' ' Shouldn't the prerequisite be called FORK rather than NON_MINGW? -- Jakub Narębski ``` ## Johannes Sixt, 2011-08-03 10:40 Subject: Re: [PATCH] Skip archive --remote tests on Windows Message-ID: <4E392584.6060509@viscovery.net> URL: https://gitlist.dev/e/4E392584.6060509%40viscovery.net In-Reply-To: ``` Am 8/3/2011 11:09, schrieb Jakub Narebski: > Johannes Sixt writes: >> -test_expect_success 'archive --list shows only enabled remote filters' ' >> +test_expect_success NOT_MINGW 'archive --list shows only enabled remote filters' ' > > Shouldn't the prerequisite be called FORK rather than NON_MINGW? Yes, it should. But we already have one instance of NOT_MINGW in connection with archive --remote in this file before this patch, and with Erik's efforts, these particular prerequisites should go away anyway RSN. -- Hannes ```