Joe PerchesMany types of signatures are used by various projects.
The most common type is formatted: "[some_signature_type]-by: First Last <email@domain.tld>" e.g: "Reported-by: First Last <email@domain.tld>" (no quotes are used)
Make git-send-email use these signatures as "CC:" entries.
Add command line option --suppress-cc=signatures to avoid adding these entries to the cc.
Signed-off-by: Joe Perches <joe@perches.com> --- Documentation/git-send-email.txt | 3 ++- git-send-email.perl | 11 ++++++----- 2 files changed, 8 insertions(+), 6 deletions(-)
Show changes to 2 files +8 −6
Documentation/git-send-email.txt, git-send-email.perl
diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt index 327233c..17ea825 100644 --- a/Documentation/git-send-email.txt +++ b/Documentation/git-send-email.txt @@ -246,8 +246,9 @@ Automating patch body (commit message) except for self (use 'self' for that). - 'sob' will avoid including anyone mentioned in Signed-off-by lines except for self (use 'self' for that). +- 'signatures' will avoid including anyone mentioned in any "<foo>-by:" lines. - 'cccmd' will avoid running the --cc-cmd. -- 'body' is equivalent to 'sob' + 'bodycc' +- 'body' is equivalent to 'sob' + 'bodycc + signatures' - 'all' will suppress all auto cc values. -- + diff --git a/git-send-email.perl b/git-send-email.perl index 98ab33a..973ed65 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -75,7 +75,7 @@ git send-email [options] <file | directory | rev-list options > --identity <str> * Use the sendemail.<id> options. --to-cmd <str> * Email To: via `<str> \$patch_path` --cc-cmd <str> * Email Cc: via `<str> \$patch_path` - --suppress-cc <str> * author, self, sob, cc, cccmd, body, bodycc, all. + --suppress-cc <str> * author, self, sob, cc, cccmd, body, bodycc, signatures, all. --[no-]signed-off-by-cc * Send to Signed-off-by: addresses. Default on. --[no-]suppress-from * Send to self. Default off. --[no-]chain-reply-to * Chain In-Reply-To: fields. Default off. @@ -374,13 +374,13 @@ my(%suppress_cc); if (@suppress_cc) { foreach my $entry (@suppress_cc) { die "Unknown --suppress-cc field: '$entry'\n" - unless $entry =~ /^(?:all|cccmd|cc|author|self|sob|body|bodycc)$/; + unless $entry =~ /^(?:all|cccmd|cc|author|self|sob|body|bodycc|signatures)$/; $suppress_cc{$entry} = 1; } } if ($suppress_cc{'all'}) { - foreach my $entry (qw (cccmd cc author self sob body bodycc)) { + foreach my $entry (qw (cccmd cc author self sob body bodycc signatures)) { $suppress_cc{$entry} = 1; } delete $suppress_cc{'all'}; @@ -391,7 +391,7 @@ $suppress_cc{'self'} = $suppress_from if defined $suppress_from; $suppress_cc{'sob'} = !$signed_off_by_cc if defined $signed_off_by_cc; if ($suppress_cc{'body'}) { - foreach my $entry (qw (sob bodycc)) { + foreach my $entry (qw (sob bodycc signatures)) { $suppress_cc{$entry} = 1; } delete $suppress_cc{'body'}; @@ -1251,7 +1251,7 @@ foreach my $t (@files) { # Now parse the message body while(<$fh>) { $message .= $_; - if (/^(Signed-off-by|Cc): (.*)$/i) { + if (/^(Signed-off-by|Cc|[a-z_-]+by): (.*)$/i) { chomp; my ($what, $c) = ($1, $2); chomp $c; @@ -1260,6 +1260,7 @@ foreach my $t (@files) { } else { next if $suppress_cc{'sob'} and $what =~ /Signed-off-by/i; next if $suppress_cc{'bodycc'} and $what =~ /Cc/i; + next if $suppress_cc{'signatures'} and $what =~ /by$/i; } push @cc, $c; printf("(body) Adding cc: %s from line '%s'\n",
-- 1.7.6.131.g99019
