Help using git I'm review process

> On 24 July 2011 13:12, Mathew Benson <mathew.benson@gmail.com> wrote:
>> I'm planning to use git for a work project, which requires tight control of the peer review process.  In previous jobs, the peer review was a tedious manual process of creating PDF files, writing comments in spreadsheets, and copying comments to the CM system.  I want to use technology to my best advantage.
>> 
>> Once a developer has completed all his changes in his development branch, what's the best way to get those files to the reviewers, without requiring the author to stop work?  First, I think I should create a tag in the developer branch.  Each developer has a local repository, and my review tool writes files directly in the work area.  Can they just fetch, checkout a tag (don't know how to do that), commit changes, and push it back to the central repository?  Is there a better workflow?--
> 
> This is what Gerrit is useful for.
> 
> -- Thomas Adam

> On 24 July 2011 13:12, Mathew Benson <mathew.benson@gmail.com> wrote:
>> I'm planning to use git for a work project, which requires tight control of the peer review process.  In previous jobs, the peer review was a tedious manual process of creating PDF files, writing comments in spreadsheets, and copying comments to the CM system.  I want to use technology to my best advantage.
>>
>> Once a developer has completed all his changes in his development branch, what's the best way to get those files to the reviewers, without requiring the author to stop work?  First, I think I should create a tag in the developer branch.  Each developer has a local repository, and my review tool writes files directly in the work area.  Can they just fetch, checkout a tag (don't know how to do that), commit changes, and push it back to the central repository?  Is there a better workflow?--
> 
> This is what Gerrit is useful for.

> Am 24.07.2011 14:16, schrieb Thomas Adam:
>> On 24 July 2011 13:12, Mathew Benson <mathew.benson@gmail.com> wrote:
>>> I'm planning to use git for a work project, which requires tight control of the peer review process.  In previous jobs, the peer review was a tedious manual process of creating PDF files, writing comments in spreadsheets, and copying comments to the CM system.  I want to use technology to my best advantage.
>>> 
>>> Once a developer has completed all his changes in his development branch, what's the best way to get those files to the reviewers, without requiring the author to stop work?  First, I think I should create a tag in the developer branch.  Each developer has a local repository, and my review tool writes files directly in the work area.  Can they just fetch, checkout a tag (don't know how to do that), commit changes, and push it back to the central repository?  Is there a better workflow?--
>> 
>> This is what Gerrit is useful for.
> 
> Yes, Gerrit is a very sophisticated way to do that.
> 
> But you can also achieve a review process by just using git and email
> too: Have each developer do each topic of his work on a separate feature
> branch and send merge requests (e.g. per email) to the reviewer when he
> is done. If the reviewer approves the changes, he merges that branch
> (and deletes the remote topic branch, as that topic is now finished and
> part of the history). If not, he requests improvements from the developer
> who updates that branch and sends another review request when he is done.
> We use this approach successfully at my dayjob.

> On 24 July 2011 13:42, Mathew Benson <mathew.benson@gmail.com> wrote:
>> I found that in my research but my IT "department" recommended a tool they're already using.  I'll push Gerrit again.  Is there an online demo?
>
> https://review.source.android.com/#/q/status:open,n,z
>
> -- Thomas Adam

> [ Don't mail me off-list; this means don't cull the CC list. ]
> 
> ---------- Forwarded message ----------
> From: Mathew Benson <mathew.benson@gmail.com>
> Date: 24 July 2011 14:58
> Subject: Re: Help using git I'm review process
> To: Thomas Adam <thomas@xteddy.org>
> 
> 
> I know Gerrit integrates with Git.  Does it integrate with Trac?
> Gerrit does understand c/c++, right?
> 
> Sent from my iPad
> 
> On Jul 24, 2011, at 7:53 AM, Thomas Adam <thomas@xteddy.org> wrote:
> 
>> On 24 July 2011 13:42, Mathew Benson <mathew.benson@gmail.com> wrote:
>>> I found that in my research but my IT "department" recommended a tool they're already using.  I'll push Gerrit again.  Is there an online demo?
>> 
>> https://review.source.android.com/#/q/status:open,n,z
>> 
>> -- Thomas Adam