threads / bug / 27752

[BUG] gitk update/reload doesn't refresh notes

Subject: [BUG] gitk update/reload doesn't refresh notes

## tl;dr

One message between Jul 4, 2011 and Jul 4, 2011.

replies: 0people: 1as markdown or json

SZEDER Gábor· Jul 4, 2011, 15:36 UTC · lore
Hi,

I would expect that when I start gitk with '--show-notes' option and press update or reload, then it updates not just the commits, but the notes shown in the log/diff window, too. However, as shown below, this is not the case.

  notes_vs_gitk$ git init
  Initialized empty Git repository in
  /home/szeder/tmp/git/notes_vs_gitk/.git/
  notes_vs_gitk (master)$ echo 1 >foo
  notes_vs_gitk (master)$ git add foo
  notes_vs_gitk (master)$ git commit -m First. foo
  [master (root-commit) 88dbd6b] First.
   1 files changed, 1 insertions(+), 0 deletions(-)
   create mode 100644 foo
  notes_vs_gitk (master)$ gitk --show-notes master &
  [1] 15673
  notes_vs_gitk (master)$ git notes add -m "Note,
  that these notes will not appear in gitk without restarting it"
  notes_vs_gitk (master)$ git log
  commit 88dbd6bf8f1e3e4fc94d1da5e73754c7d2f0f244
  Author: SZEDER Gábor <szeder@ira.uka.de>
  Date:   2011-07-04 17:18:28 +0200
  
      First.
  
  Notes:
      Note, that these notes will not appear in gitk without restarting it
  
  # Press F5 in gitk for update.
  # Nope, notes are not shown.
  # Press ctrl-F5 in gitk for reload.
  # Notes are still not shown.
  
  notes_vs_gitk (master)$ kill %1
  [1]+  Terminated              gitk --show-notes master
  notes_vs_gitk (master)$ gitk --show-notes master &
  [1] 15826
  
  # Notes are shown, finally.
  notes_vs_gitk (master)$ git notes remove 
  Removing note for object HEAD
  # Press F5/ctrl-F5 in gitk.
  # The removed notes are still there.

Best, Gábor

← back to recent threads