threads / bug / 27700

BUG: 'cherry-pick -x' corner case

Subject: BUG: 'cherry-pick -x' corner case

## tl;dr

One message between Jun 24, 2011 and Jun 24, 2011.

replies: 0people: 1as markdown or json

Eric Raible· Jun 24, 2011, 21:54 UTC · lore

When cherry-picking a (presumably trivial) commit that has only the one-line summary (and no further text), cherry-pick -x appends it's message directly to the one-line summary.

Thereby creating a commit which has a two-line summary.

Aside from that, even with a non-trivial commit the generated note "(cherry picked from commit 555c9864971744abb558796aea28e12a1ac20839)" seems abrupt when appended directly.

I'd suggest:
"\n[cherry-picked from commit 555c9864971744abb558796aea28e12a1ac20839]"
or even better:
"\n[cherry-picked from commit 555c986]"
I'll turn this into an actual patch if there's a chance of it being incorporated.
- Eric

← back to recent threads