# pre-commit hook to reject whitespace 4 messages from 2011-06-03 to 2011-06-04. Participants: Neal Kreitzinger, John Szakmeister. Thread: https://gitlist.dev/t/27542 ## Neal Kreitzinger, 2011-06-03 23:31 Subject: pre-commit hook to reject whitespace Message-ID: URL: https://gitlist.dev/e/isbqsf%24vh8%241%40dough.gmane.org ``` The reference manuals state in the hooks documentation that the pre-commit hook sample will reject whitespace only changes. However, the pre-commit.sample in the 1.7.1 and 1.7.5.4 downloads do not appear to do this (I'm new to linux scripts). The appear to only reject non-ascii filenames. Does someone have a pre-commit hook example I can use to reject whitespace-only changes? Thanks! v/r, neal ``` ## Neal Kreitzinger, 2011-06-03 23:58 Subject: Re: pre-commit hook to reject whitespace Message-ID: URL: https://gitlist.dev/e/isbsf8%246id%241%40dough.gmane.org In-Reply-To: ``` On 6/3/2011 6:31 PM, Neal Kreitzinger wrote: > The reference manuals state in the hooks documentation that the pre-commit > hook sample will reject whitespace only changes. However, the > pre-commit.sample in the 1.7.1 and 1.7.5.4 downloads do not appear to do > this (I'm new to linux scripts). The appear to only reject non-ascii > filenames. Does someone have a pre-commit hook example I can use to reject > whitespace-only changes? Thanks! > As someone kindly pointed out, the documentation actually says: "The default 'pre-commit' hook, when enabled, catches introduction of lines with trailing whitespaces and aborts the commit when such a line is found." I'm not seeing this functionality in the pre-commit.sample for 1.7.1 or 1.7.5.4. v/r, neal ``` ## John Szakmeister, 2011-06-04 00:12 Subject: Re: pre-commit hook to reject whitespace Message-ID: URL: https://gitlist.dev/e/BANLkTi%3DGh9CStVkgp5gBs7XzG-dCXB%2BoUw%40mail.gmail.com In-Reply-To: ``` On Fri, Jun 3, 2011 at 7:58 PM, Neal Kreitzinger wrote: > On 6/3/2011 6:31 PM, Neal Kreitzinger wrote: >> >> The reference manuals state in the hooks documentation that the pre-commit >> hook sample will reject whitespace only changes.  However, the >> pre-commit.sample in the 1.7.1 and 1.7.5.4 downloads do not appear to do >> this (I'm new to linux scripts).  The appear to only reject non-ascii >> filenames.  Does someone have a pre-commit hook example I can use to >> reject >> whitespace-only changes?  Thanks! >> > As someone kindly pointed out, the documentation actually says: > "The default 'pre-commit' hook, when enabled, catches introduction of lines > with trailing whitespaces and aborts the commit when such a line is found." > > I'm not seeing this functionality in the pre-commit.sample for 1.7.1 or > 1.7.5.4. I've never tried that hook script myself, but it appears to be on the last line: exec git diff-index --check --cached $against -- In particular, the --check option says: Warn if changes introduce trailing whitespace or an indent that uses a space before a tab. Exits with non-zero status if problems are found. Not compatible with --exit-code. HTH! -John ``` ## Neal Kreitzinger, 2011-06-04 00:23 Subject: Re: pre-commit hook to reject whitespace Message-ID: <4DE97B10.8080006@gmail.com> URL: https://gitlist.dev/e/4DE97B10.8080006%40gmail.com In-Reply-To: ``` On 6/3/2011 7:12 PM, John Szakmeister wrote: > On Fri, Jun 3, 2011 at 7:58 PM, Neal Kreitzinger wrote: >> On 6/3/2011 6:31 PM, Neal Kreitzinger wrote: >>> >>> The reference manuals state in the hooks documentation that the pre-commit >>> hook sample will reject whitespace only changes. However, the >>> pre-commit.sample in the 1.7.1 and 1.7.5.4 downloads do not appear to do >>> this (I'm new to linux scripts). The appear to only reject non-ascii >>> filenames. Does someone have a pre-commit hook example I can use to >>> reject >>> whitespace-only changes? Thanks! >>> >> As someone kindly pointed out, the documentation actually says: >> "The default 'pre-commit' hook, when enabled, catches introduction of lines >> with trailing whitespaces and aborts the commit when such a line is found." >> >> I'm not seeing this functionality in the pre-commit.sample for 1.7.1 or >> 1.7.5.4. > > I've never tried that hook script myself, but it appears to be on the last line: > exec git diff-index --check --cached $against -- > > In particular, the --check option says: > Warn if changes introduce trailing whitespace or an indent that > uses a space before a tab. Exits with non-zero status if problems are > found. Not compatible with --exit-code. > Ah ha! Thanks! v/r, neal ```