# [PATCH] remove tests of always-false condition 2 messages from 2011-05-26 to 2011-05-26. Participants: Jim Meyering, Junio C Hamano. Thread: https://gitlist.dev/t/27466 ## Jim Meyering, 2011-05-26 13:58 Subject: [PATCH] remove tests of always-false condition Message-ID: <87zkm95zt3.fsf@rho.meyering.net> URL: https://gitlist.dev/e/87zkm95zt3.fsf%40rho.meyering.net ``` * fsck.c (fsck_error_function): Don't test obj->sha1 == 0. It can never be true, since that sha1 member is an array. * transport.c (set_upstreams): Likewise for ref->new_sha1. Signed-off-by: Jim Meyering --- Fix some coverity-spotted nits. Relative to "next". fsck.c | 2 +- transport.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fsck.c b/fsck.c index 6f266c1..60bd4bb 100644 --- a/fsck.c +++ b/fsck.c @@ -349,7 +349,7 @@ int fsck_error_function(struct object *obj, int type, const char *fmt, ...) va_list ap; struct strbuf sb = STRBUF_INIT; - strbuf_addf(&sb, "object %s:", obj->sha1?sha1_to_hex(obj->sha1):"(null)"); + strbuf_addf(&sb, "object %s:", sha1_to_hex(obj->sha1)); va_start(ap, fmt); strbuf_vaddf(&sb, fmt, ap); diff --git a/transport.c b/transport.c index 1a3998e..c9c8056 100644 --- a/transport.c +++ b/transport.c @@ -156,7 +156,7 @@ static void set_upstreams(struct transport *transport, struct ref *refs, continue; if (!ref->peer_ref) continue; - if (!ref->new_sha1 || is_null_sha1(ref->new_sha1)) + if (is_null_sha1(ref->new_sha1)) continue; /* Follow symbolic refs (mainly for HEAD). */ -- 1.7.5.2.660.g9f46c ``` ## Junio C Hamano, 2011-05-26 18:23 Subject: Re: [PATCH] remove tests of always-false condition Message-ID: <7v39k1xqvh.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7v39k1xqvh.fsf%40alter.siamese.dyndns.org In-Reply-To: <87zkm95zt3.fsf@rho.meyering.net> ``` Jim Meyering writes: > Relative to "next". I don't appreciate this comment especially for a patch that applies cleanly to "maint". But other than that, fine. Thanks. ```