[PATCH] setup.c: Fix some "symbol not declared" sparse warnings

Ramsay Jones· May 17, 2011, 17:43 UTC · lore

In particular, sparse issues the "symbol 'a_symbol' was not declared. Should it be static?" warnings for the following symbols:

    setup.c:159:3: 'pathspec_magic'
    setup.c:176:12: 'prefix_pathspec'

These symbols only require file scope, so we add the static modifier to their declarations.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---

Hi Junio,

I noticed these sparse warnings on the next branch (as of a few days ago).

ATB, Ramsay Jones

 setup.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Show changes to setup.c +2 −2

diff --git a/setup.c b/setup.c
index 58dc16c..013ad11 100644
--- a/setup.c
+++ b/setup.c
@@ -152,7 +152,7 @@ void verify_non_filename(const char *prefix, const char *arg)
  */
 #define PATHSPEC_FROMTOP    (1<<0)
 
-struct pathspec_magic {
+static struct pathspec_magic {
 	unsigned bit;
 	char mnemonic; /* this cannot be ':'! */
 	const char *name;
@@ -173,7 +173,7 @@ struct pathspec_magic {
  * the prefix part must always match literally, and a single stupid
  * string cannot express such a case.
  */
-const char *prefix_pathspec(const char *prefix, int prefixlen, const char *elt)
+static const char *prefix_pathspec(const char *prefix, int prefixlen, const char *elt)
 {
 	unsigned magic = 0;
 	const char *copyfrom = elt;

-- 
1.7.5

patchsetup.c: Fix some "symbol not declared" sparse warnings