# [PATCH] copy_gecos: fix not adding nlen to len when processing "&" 2 messages from 2011-05-16 to 2011-05-18. Participants: Rafael Gieschke, Junio C Hamano. Thread: https://gitlist.dev/t/27375 ## Rafael Gieschke, 2011-05-16 20:08 Subject: [PATCH] copy_gecos: fix not adding nlen to len when processing "&" Message-ID: URL: https://gitlist.dev/e/F0632D34-AA49-48B6-B54E-208B14F3FA90%40gieschke.de ``` nlen has to be added to len when inserting (capitalized) pw_name as substitution for "&" in pw_gecos. Otherwise, pw_gecos will be truncated and data might be written beyond name+sz. Signed-off-by: Rafael Gieschke --- ident.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/ident.c b/ident.c index 1c4adb0..8e56b5e 100644 --- a/ident.c +++ b/ident.c @@ -34,6 +34,7 @@ static void copy_gecos(const struct passwd *w, char *name, size_t sz) *dst++ = toupper(*w->pw_name); memcpy(dst, w->pw_name + 1, nlen - 1); dst += nlen - 1; + len += nlen; } } if (len < sz) -- 1.7.4 ``` ## Junio C Hamano, 2011-05-18 04:28 Subject: Re: [PATCH] copy_gecos: fix not adding nlen to len when processing "&" Message-ID: <7vipt8eip4.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vipt8eip4.fsf%40alter.siamese.dyndns.org In-Reply-To: ``` Thanks, will queue. ```