# [PATCH] git-send-email: fix missing space in error message 4 messages from 2011-04-29 to 2011-04-30. Participants: Sylvain Rabot, Junio C Hamano. Thread: https://gitlist.dev/t/27225 ## Sylvain Rabot, 2011-04-29 18:23 Subject: [PATCH] git-send-email: fix missing space in error message Message-ID: <1304101404-4571-1-git-send-email-sylvain@abstraction.fr> URL: https://gitlist.dev/e/1304101404-4571-1-git-send-email-sylvain%40abstraction.fr ``` Signed-off-by: Sylvain Rabot --- git-send-email.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/git-send-email.perl b/git-send-email.perl index 76565de..98ab33a 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -1091,7 +1091,7 @@ X-Mailer: git-send-email $gitversion "VALUES: server=$smtp_server ", "encryption=$smtp_encryption ", "hello=$smtp_domain", - defined $smtp_server_port ? "port=$smtp_server_port" : ""; + defined $smtp_server_port ? " port=$smtp_server_port" : ""; } if (defined $smtp_authuser) { -- 1.7.5 ``` ## Junio C Hamano, 2011-04-29 18:33 Subject: Re: [PATCH] git-send-email: fix missing space in error message Message-ID: <7vmxj8x5yj.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vmxj8x5yj.fsf%40alter.siamese.dyndns.org In-Reply-To: <1304101404-4571-1-git-send-email-sylvain@abstraction.fr> ``` Sylvain Rabot writes: > Signed-off-by: Sylvain Rabot Please keep in mind that these individual commits will eventually need an entry added to Documentation/Relnotes/1.7.5.1.txt where I describe what bug was fixed in a single paragraph, and it almost always talks about how a bug would have been triggered so that the readers can tell if the fix would benefit them. It would have been perfect if you wrote under what condition the user would see this error message in the body of the commit. > --- > git-send-email.perl | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/git-send-email.perl b/git-send-email.perl > index 76565de..98ab33a 100755 > --- a/git-send-email.perl > +++ b/git-send-email.perl > @@ -1091,7 +1091,7 @@ X-Mailer: git-send-email $gitversion > "VALUES: server=$smtp_server ", > "encryption=$smtp_encryption ", > "hello=$smtp_domain", > - defined $smtp_server_port ? "port=$smtp_server_port" : ""; > + defined $smtp_server_port ? " port=$smtp_server_port" : ""; If I were writing this from scratch, I probably would have written it by having leading SP for all options, perhaps like this: "VALUES:", " option=value", " option=value", (showoption) ? " option=value" : "", (showoption) ? " option=value" : "", ... Thanks. ``` ## Junio C Hamano, 2011-04-29 18:37 Subject: Re: [PATCH] git-send-email: fix missing space in error message Message-ID: <7viptwx5s4.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7viptwx5s4.fsf%40alter.siamese.dyndns.org In-Reply-To: <7vmxj8x5yj.fsf@alter.siamese.dyndns.org> ``` Junio C Hamano writes: > Sylvain Rabot writes: > >> Signed-off-by: Sylvain Rabot > > Please keep in mind that these individual commits will eventually need an > entry added to Documentation/Relnotes/1.7.5.1.txt where I describe what > bug was fixed in a single paragraph, and it almost always talks about how > a bug would have been triggered so that the readers can tell if the fix > would benefit them. > > It would have been perfect if you wrote under what condition the user > would see this error message in the body of the commit. Will queue this; thanks. Author: Sylvain Rabot Date: Fri Apr 29 20:23:24 2011 +0200 git-send-email: fix missing space in error message When the command cannot make a connection to the SMTP server the error message to diagnose the broken configuration is issued. However, when an optional smtp-server-port is given and needs to be reported, the message lacked a space between "hello=" and "port=". Signed-off-by: Sylvain Rabot Signed-off-by: Junio C Hamano ``` ## Sylvain Rabot, 2011-04-30 07:52 Subject: Re: [PATCH] git-send-email: fix missing space in error message Message-ID: <1304149959.1850.4.camel@kheops> URL: https://gitlist.dev/e/1304149959.1850.4.camel%40kheops In-Reply-To: <7vmxj8x5yj.fsf@alter.siamese.dyndns.org> ``` Sorry about that. Was thinking this was not worth an entry in the release note. On Fri, 2011-04-29 at 11:33 -0700, Junio C Hamano wrote: > Sylvain Rabot writes: > > > Signed-off-by: Sylvain Rabot > > Please keep in mind that these individual commits will eventually need an > entry added to Documentation/Relnotes/1.7.5.1.txt where I describe what > bug was fixed in a single paragraph, and it almost always talks about how > a bug would have been triggered so that the readers can tell if the fix > would benefit them. > > It would have been perfect if you wrote under what condition the user > would see this error message in the body of the commit. > > > --- > > git-send-email.perl | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/git-send-email.perl b/git-send-email.perl > > index 76565de..98ab33a 100755 > > --- a/git-send-email.perl > > +++ b/git-send-email.perl > > @@ -1091,7 +1091,7 @@ X-Mailer: git-send-email $gitversion > > "VALUES: server=$smtp_server ", > > "encryption=$smtp_encryption ", > > "hello=$smtp_domain", > > - defined $smtp_server_port ? "port=$smtp_server_port" : ""; > > + defined $smtp_server_port ? " port=$smtp_server_port" : ""; > > If I were writing this from scratch, I probably would have written it > by having leading SP for all options, perhaps like this: > > "VALUES:", > " option=value", > " option=value", > (showoption) ? " option=value" : "", > (showoption) ? " option=value" : "", > ... > > Thanks. ```