threads / patch / 2715

patchDo not attempt to access literal dirname "GIT_OBJECT_DIRECTORY".

Subject: [PATCH] Do not attempt to access literal dirname "GIT_OBJECT_DIRECTORY".

## tl;dr

One message between Nov 30, 2005 and Nov 30, 2005. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Tommi Virtanen· Nov 30, 2005, 15:37 UTC · lore
Dereference the environment variable before using it.
Signed-off-by: Tommi Virtanen <tv@inoi.fi>
---
 setup.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

applies-to: fa10b18d1546129bf73713b64fbc4a8feae3487f a4a0e60f920f906284f4f6a4d3b4ffb043834bc7

Show changes to setup.c +1 −1
diff --git a/setup.c b/setup.c
index cc44a72..3286a56 100644
--- a/setup.c
+++ b/setup.c
@@ -116,7 +116,7 @@ static const char *setup_git_directory_1
 		if (validate_symref(path))
 			goto bad_dir_environ;
 		if (getenv(DB_ENVIRONMENT)) {
-			if (access(DB_ENVIRONMENT, X_OK))
+			if (access(getenv(DB_ENVIRONMENT), X_OK))
 				goto bad_dir_environ;
 		}
 		else {
---
0.99.9.GIT

← back to recent threads