threads / patch / 2674

patchFix segfault in git-shell when given no argument.

Subject: [PATCH] Fix segfault in git-shell when given no argument.

## tl;dr

One message between Nov 25, 2005 and Nov 25, 2005. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Tommi Virtanen· Nov 25, 2005, 11:49 UTC · lore
The bug is trivially reproducible with "git-shell -c git-receive-pack"
Signed-off-by: Tommi Virtanen <tv@inoi.fi>
---
 shell.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

applies-to: 2ada0cb8fce070b6b2c56fa689791230636f1857 4fbfea212a9afcd123a213e20388b1fa775fc7fe

Show changes to shell.c +2 −0
diff --git a/shell.c b/shell.c
index 2c4789e..7fab432 100644
--- a/shell.c
+++ b/shell.c
@@ -5,6 +5,8 @@ static int do_generic_cmd(const char *me
 {
 	const char *my_argv[4];
 
+	if (!arg)
+		die("missing argument");
 	arg = sq_dequote(arg);
 	if (!arg)
 		die("bad argument");
---
0.99.9.GIT

← back to recent threads