threads / patch / 26727

patchobject.h: Remove obsolete struct object_refs

Subject: [PATCH] object.h: Remove obsolete struct object_refs

## tl;dr

3 messages between Mar 14, 2011 and Mar 14, 2011. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Jakob Pfender· Mar 14, 2011, 16:23 UTC · lore

The struct object_refs in object.h is never used anywhere, so remove it.

Signed-off-by: Jakob Pfender <jpfender@elegosoft.com>
---
  object.h |    5 -----
  1 files changed, 0 insertions(+), 5 deletions(-)

Show changes to object.h +0 −5

diff --git a/object.h b/object.h
index 4d1d615..b6618d9 100644
--- a/object.h
+++ b/object.h
@@ -6,11 +6,6 @@ struct object_list {
  	struct object_list *next;
  };

-struct object_refs {
-	unsigned count;
-	struct object *ref[FLEX_ARRAY]; /* more */
-};
-
  struct object_array {
  	unsigned int nr;
  	unsigned int alloc;

-- 
1.7.0.4

Michael J Gruber· Mar 14, 2011, 17:03 UTC · re: Jakob Pfender · lore

Re: [PATCH] object.h: Remove obsolete struct object_refs

Jakob Pfender venit, vidit, dixit 14.03.2011 17:23:

> The struct object_refs in object.h is never used anywhere, so remove it.
>

Maybe you could add the information that it is unused since

7914053 (Remove unused object-ref code, 2008-02-25)

That saves everyone else a pickaxe :)

Michael

Junio C Hamano· Mar 14, 2011, 17:48 UTC · re: Jakob Pfender · lore

Re: [PATCH] object.h: Remove obsolete struct object_refs

Jakob Pfender <jpfender@elegosoft.com> writes:

> The struct object_refs in object.h is never used anywhere, so remove it.
>
> Signed-off-by: Jakob Pfender <jpfender@elegosoft.com>

Thanks; I'd rephrase the above like this (no need to resend):

	7914053 (Remove unused object-ref code, 2008-02-25) removed
        all uses of the structure from the code, but forgot to remove
        the type definition itself.

Thanks.