# [TopGit PATCH] tg-create: let format.signoff control adding of Signed-off-by

1 messages from 2011-03-07 to 2011-03-07. Participants: Andrey Borzenkov.
Thread: https://gitlist.dev/t/26681

## Andrey Borzenkov, 2011-03-07 10:42

Subject: [TopGit PATCH] tg-create: let format.signoff control adding of Signed-off-by
Message-ID: <1299494566-13021-1-git-send-email-arvidjaar@gmail.com>
URL: https://gitlist.dev/e/1299494566-13021-1-git-send-email-arvidjaar%40gmail.com

```
GIT manual stresses that adding of Signed-off-by should be explicit
user decision. Some projects do ask for no Signed-off-by lines. So
make sure it is added by tg-create.sh only when explicity requested
by user.

Signed-off-by: Andrey Borzenkov <arvidjaar@gmail.com>

---
 tg-create.sh |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/tg-create.sh b/tg-create.sh
index 2edd537..617031b 100644
--- a/tg-create.sh
+++ b/tg-create.sh
@@ -129,11 +129,9 @@ author_addr="${author%> *}>"
 	! subject_prefix="$(git config topgit.subjectprefix)" || subject_prefix="$subject_prefix "
 	echo "Subject: [${subject_prefix}PATCH] $name"
 	echo
-	cat <<EOT
-<patch description>
-
-Signed-off-by: $author_addr
-EOT
+	echo '<patch description>'
+	echo
+	[ "$(git config --bool format.signoff)" = true ] && echo "Signed-off-by: $author_addr"
 } >"$root_dir/.topmsg"
 git add -f "$root_dir/.topmsg"
 
-- 
tg: (d279e29..) u/signed-off-by (depends on: master)

```