threads / discuss / 26569

how a patch can be accepted?

Subject: how a patch can be accepted?

## tl;dr

11 messages between Feb 21, 2011 and Mar 3, 2011.

replies: 10people: 4as markdown or json

xzer· Feb 21, 2011, 14:48 UTC · lore
Hi,

I submitted a patch recently by sending a mail to this mail list, but I don't know how it can be accepted or rejected? Is that enough just send a mail to here? Because the patch is a very important fix to my usage and I don't want to apply it every time by myself.

Best Regards yours xzer

Ævar Arnfjörð Bjarmason· Feb 21, 2011, 16:23 UTC · re: xzer · lore

Re: how a patch can be accepted?

On Mon, Feb 21, 2011 at 15:48, xzer <xiaozhu@gmail.com> wrote:
> I submitted a patch recently by sending a mail to this mail list, but
> I don't know how it can be accepted or rejected? Is that enough just
> send a mail to here? Because the patch is a very important fix to my
> usage and I don't want to apply it every time by myself.
Did you read Documentation/SubmittingPatches?
xiaozhu· Feb 22, 2011, 13:56 UTC · re: Ævar Arnfjörð Bjarmason · lore

Re: how a patch can be accepted?

On 2011/02/22 1:23, Ævar Arnfjörð Bjarmason wrote:
Show 7 quoted lines
> On Mon, Feb 21, 2011 at 15:48, xzer<xiaozhu@gmail.com>  wrote:
>> I submitted a patch recently by sending a mail to this mail list, but
>> I don't know how it can be accepted or rejected? Is that enough just
>> send a mail to here? Because the patch is a very important fix to my
>> usage and I don't want to apply it every time by myself.
>
> Did you read Documentation/SubmittingPatches?

Where is the Documentation/SubmittingPatches? I didn't see anything about submitting a patch on the site of git, and I also tried to find something about it on git wiki, but I got nothing.

Erik Faye-Lund· Feb 22, 2011, 14:08 UTC · re: xiaozhu · lore

Re: how a patch can be accepted?

On Tue, Feb 22, 2011 at 2:56 PM, xiaozhu <xiaozhu@gmail.com> wrote:
Show 14 quoted lines
> On 2011/02/22 1:23, Ævar Arnfjörð Bjarmason wrote:
>>
>> On Mon, Feb 21, 2011 at 15:48, xzer<xiaozhu@gmail.com>  wrote:
>>>
>>> I submitted a patch recently by sending a mail to this mail list, but
>>> I don't know how it can be accepted or rejected? Is that enough just
>>> send a mail to here? Because the patch is a very important fix to my
>>> usage and I don't want to apply it every time by myself.
>>
>> Did you read Documentation/SubmittingPatches?
>
> Where is the Documentation/SubmittingPatches? I didn't see anything
> about submitting a patch on the site of git, and I also tried to find
> something about it on git wiki, but I got nothing.
It's in the Git source tree.
xiaozhu· Feb 22, 2011, 14:28 UTC · re: Erik Faye-Lund · lore

Re: how a patch can be accepted?

On 2011/02/22 23:08, Erik Faye-Lund wrote:
Show 17 quoted lines
> On Tue, Feb 22, 2011 at 2:56 PM, xiaozhu<xiaozhu@gmail.com>  wrote:
>> On 2011/02/22 1:23, Ævar Arnfjörð Bjarmason wrote:
>>>
>>> On Mon, Feb 21, 2011 at 15:48, xzer<xiaozhu@gmail.com>    wrote:
>>>>
>>>> I submitted a patch recently by sending a mail to this mail list, but
>>>> I don't know how it can be accepted or rejected? Is that enough just
>>>> send a mail to here? Because the patch is a very important fix to my
>>>> usage and I don't want to apply it every time by myself.
>>>
>>> Did you read Documentation/SubmittingPatches?
>>
>> Where is the Documentation/SubmittingPatches? I didn't see anything
>> about submitting a patch on the site of git, and I also tried to find
>> something about it on git wiki, but I got nothing.
>
> It's in the Git source tree.
Thank you very much, I got it.
Sverre Rabbelier· Feb 24, 2011, 00:04 UTC · re: xiaozhu · lore

Re: how a patch can be accepted?

Heya,
On Tue, Feb 22, 2011 at 14:56, xiaozhu <xiaozhu@gmail.com> wrote:
Show 6 quoted lines
> On 2011/02/22 1:23, Ævar Arnfjörð Bjarmason wrote:
>> Did you read Documentation/SubmittingPatches?
>
> Where is the Documentation/SubmittingPatches? I didn't see anything
> about submitting a patch on the site of git, and I also tried to find
> something about it on git wiki, but I got nothing.
I've added a link on the wiki [0] to the kernel.org 'cat blob' view.
[0] https://git.wiki.kernel.org/index.php/Main_Page#Starting_points
-- 
Cheers,

Sverre Rabbelier
Erik Faye-Lund· Feb 24, 2011, 09:11 UTC · re: Sverre Rabbelier · lore

Re: how a patch can be accepted?

On Thu, Feb 24, 2011 at 1:04 AM, Sverre Rabbelier <srabbelier@gmail.com> wrote:
Show 14 quoted lines
> Heya,
>
> On Tue, Feb 22, 2011 at 14:56, xiaozhu <xiaozhu@gmail.com> wrote:
>> On 2011/02/22 1:23, Ævar Arnfjörð Bjarmason wrote:
>>> Did you read Documentation/SubmittingPatches?
>>
>> Where is the Documentation/SubmittingPatches? I didn't see anything
>> about submitting a patch on the site of git, and I also tried to find
>> something about it on git wiki, but I got nothing.
>
> I've added a link on the wiki [0] to the kernel.org 'cat blob' view.
>
> [0] https://git.wiki.kernel.org/index.php/Main_Page#Starting_points
>

Did you really? I can't find it, neither on the linked page nor a matching entry on the recent changes page: https://git.wiki.kernel.org/index.php/Special:RecentChanges

Sverre Rabbelier· Feb 24, 2011, 10:15 UTC · re: Erik Faye-Lund · lore

Re: how a patch can be accepted?

Heya,
On Thu, Feb 24, 2011 at 10:11, Erik Faye-Lund <kusmabite@gmail.com> wrote:
> Did you really? I can't find it, neither on the linked page nor a
> matching entry on the recent changes page:
> https://git.wiki.kernel.org/index.php/Special:RecentChanges

Yup, I really did: http://awesomescreenshot.com/00184rv7c. No idea why it's not showing up in the history though.

-- 
Cheers,

Sverre Rabbelier
Sverre Rabbelier· Feb 24, 2011, 10:17 UTC · re: Sverre Rabbelier · lore

Re: how a patch can be accepted?

Heya,
On Thu, Feb 24, 2011 at 11:15, Sverre Rabbelier <srabbelier@gmail.com> wrote:
> Yup, I really did: http://awesomescreenshot.com/00184rv7c. No idea why
> it's not showing up in the history though.

Wait what.... it's only showing the change if I'm logged in. It's probably pending moderation or somesuch.

-- 
Cheers,

Sverre Rabbelier
Erik Faye-Lund· Feb 24, 2011, 10:19 UTC · re: Sverre Rabbelier · lore

Re: how a patch can be accepted?

On Thu, Feb 24, 2011 at 11:17 AM, Sverre Rabbelier <srabbelier@gmail.com> wrote:
Show 9 quoted lines
> Heya,
>
> On Thu, Feb 24, 2011 at 11:15, Sverre Rabbelier <srabbelier@gmail.com> wrote:
>> Yup, I really did: http://awesomescreenshot.com/00184rv7c. No idea why
>> it's not showing up in the history though.
>
> Wait what.... it's only showing the change if I'm logged in. It's
> probably pending moderation or somesuch.
>

Maybe something like that... It doesn't show up here: http://awesomescreenshot.com/05884s8e4

Sverre Rabbelier· Mar 3, 2011, 02:02 UTC · re: Erik Faye-Lund · lore

Re: how a patch can be accepted?

Heya,
On Thu, Feb 24, 2011 at 11:19, Erik Faye-Lund <kusmabite@gmail.com> wrote:
> Maybe something like that... It doesn't show up here:
Seems someone approved it, it's up now.
-- 
Cheers,

Sverre Rabbelier

← back to recent threads