# [PATCH 0/3] Git rename detection improvements

3 messages from 2011-02-19 to 2011-02-19. Participants: Linus Torvalds, Junio C Hamano.
Thread: https://gitlist.dev/t/26555

## Linus Torvalds, 2011-02-19 04:22

Subject: [PATCH 0/3] Git rename detection improvements
Message-ID: <AANLkTi=+5w6=-RCge3n=bv-5CLBbdY3bNVGcepyz7HrR@mail.gmail.com>
URL: https://gitlist.dev/e/AANLkTi%3D%2B5w6%3D-RCge3n%3Dbv-5CLBbdY3bNVGcepyz7HrR%40mail.gmail.com

```
Ok, so this is a cleaned-up series of three commits that I think are
worthy of being considered for inclusion. They're against current
master, maybe I should have done it against pu or next, but I doubt it
really clashes with anything, since the code hasn't changed recently
afaik.

                          Linus

---

Linus Torvalds (3):
  for_each_hash: allow passing a 'void *data' pointer to callback
  diffcore-rename: propler honor the difference between -M and -C
  diffcore-rename: improve estimate_similarity() heuristics

 builtin/describe.c             |    4 +-
 diffcore-rename.c              |   69 ++++++++++++++++++++-------------------
 hash.c                         |    4 +-
 hash.h                         |    2 +-
 t/t4003-diff-rename-1.sh       |    2 +-
 t/t4004-diff-rename-symlink.sh |    2 +-
 t/t4005-diff-rename-2.sh       |    2 +-
 t/t4008-diff-break-rewrite.sh  |    4 +-
 t/t4009-diff-rename-4.sh       |    2 +-
 9 files changed, 46 insertions(+), 45 deletions(-)

--
1.7.4.1.51.g2bf8a

```

## Junio C Hamano, 2011-02-19 06:57

Subject: Re: [PATCH 0/3] Git rename detection improvements
Message-ID: <7vlj1cmryj.fsf@alter.siamese.dyndns.org>
URL: https://gitlist.dev/e/7vlj1cmryj.fsf%40alter.siamese.dyndns.org
In-Reply-To: <AANLkTi=+5w6=-RCge3n=bv-5CLBbdY3bNVGcepyz7HrR@mail.gmail.com>

```
Linus Torvalds <torvalds@linux-foundation.org> writes:

> Ok, so this is a cleaned-up series of three commits that I think are
> worthy of being considered for inclusion.

Thanks; they all look very sane.  There indeed is a small conflict with a
topic in 'pu', but the resolution is straightforward.

> Linus Torvalds (3):
>   for_each_hash: allow passing a 'void *data' pointer to callback
>   diffcore-rename: propler honor the difference between -M and -C
>   diffcore-rename: improve estimate_similarity() heuristics

I would suggest s/propler/properly/, though...

```

## Linus Torvalds, 2011-02-19 15:31

Subject: Re: [PATCH 0/3] Git rename detection improvements
Message-ID: <AANLkTikbcy=nO_efAoBcR=+q9AxEKb8D6yrFV+9uQyCq@mail.gmail.com>
URL: https://gitlist.dev/e/AANLkTikbcy%3DnO_efAoBcR%3D%2Bq9AxEKb8D6yrFV%2B9uQyCq%40mail.gmail.com
In-Reply-To: <7vlj1cmryj.fsf@alter.siamese.dyndns.org>

```
On Fri, Feb 18, 2011 at 10:57 PM, Junio C Hamano <gitster@pobox.com> wrote:
>
> I would suggest s/propler/properly/, though...

Hey, if you don't like my creative spelling... Snif.

                    Linus

```
