# [PATCH 1/3] git-p4: Improve rename detection support 2 messages from 2011-02-18 to 2011-02-19. Participants: Vitor Antunes, Pete Wyckoff. Thread: https://gitlist.dev/t/26541 ## Vitor Antunes, 2011-02-18 00:23 Subject: [PATCH 1/3] git-p4: Improve rename detection support Message-ID: <1297988600-7002-1-git-send-email-vitor.hda@gmail.com> URL: https://gitlist.dev/e/1297988600-7002-1-git-send-email-vitor.hda%40gmail.com ``` Only open files for edit after integrating if the SHA1 of source and destination differ from each other. Add git config option detectRenames to allow permanent rename detection. This options should be set to a true/false value. Rename "detectRename" variable to "detectRenames" to make it more coherent with the description in git man pages, which always use plural. Signed-off-by: Vitor Antunes --- contrib/fast-import/git-p4 | 19 +++++++++++++++---- 1 files changed, 15 insertions(+), 4 deletions(-) diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4 index a92beb6..b0da28a 100755 --- a/contrib/fast-import/git-p4 +++ b/contrib/fast-import/git-p4 @@ -543,13 +543,13 @@ class P4Submit(Command): self.options = [ optparse.make_option("--verbose", dest="verbose", action="store_true"), optparse.make_option("--origin", dest="origin"), - optparse.make_option("-M", dest="detectRename", action="store_true"), + optparse.make_option("-M", dest="detectRenames", action="store_true"), ] self.description = "Submit changes from git to the perforce depot." self.usage += " [name of git branch to submit into perforce depot]" self.interactive = True self.origin = "" - self.detectRename = False + self.detectRenames = False self.verbose = False self.isWindows = (platform.system() == "Windows") @@ -613,7 +613,16 @@ class P4Submit(Command): def applyCommit(self, id): print "Applying %s" % (read_pipe("git log --max-count=1 --pretty=oneline %s" % id)) - diffOpts = ("", "-M")[self.detectRename] + + if not self.detectRenames: + # If not explicitly set check the config variable + self.detectRenames = gitConfig("git-p4.detectRenames").lower() == "true" + + if self.detectRenames: + diffOpts = "-M" + else: + diffOpts = "" + diff = read_pipe_lines("git diff-tree -r %s \"%s^\" \"%s\"" % (diffOpts, id, id)) filesToAdd = set() filesToDelete = set() @@ -640,8 +649,10 @@ class P4Submit(Command): elif modifier == "R": src, dest = diff['src'], diff['dst'] p4_system("integrate -Dt \"%s\" \"%s\"" % (src, dest)) - p4_system("edit \"%s\"" % (dest)) + if diff['src_sha1'] != diff['dst_sha1']: + p4_system("edit \"%s\"" % (dest)) if isModeExecChanged(diff['src_mode'], diff['dst_mode']): + p4_system("edit \"%s\"" % (dest)) filesToChangeExecBit[dest] = diff['dst_mode'] os.unlink(dest) editedFiles.add(dest) -- 1.7.2.3 ``` ## Pete Wyckoff, 2011-02-19 12:13 Subject: Re: [PATCH 1/3] git-p4: Improve rename detection support Message-ID: <20110219121328.GA5065@arf.padd.com> URL: https://gitlist.dev/e/20110219121328.GA5065%40arf.padd.com In-Reply-To: <1297988600-7002-1-git-send-email-vitor.hda@gmail.com> ``` vitor.hda@gmail.com wrote on Fri, 18 Feb 2011 00:23 +0000: > Only open files for edit after integrating if the SHA1 of source and destination > differ from each other. > Add git config option detectRenames to allow permanent rename detection. This > options should be set to a true/false value. > Rename "detectRename" variable to "detectRenames" to make it more coherent with > the description in git man pages, which always use plural. > > Signed-off-by: Vitor Antunes Clean change now, thanks. Acked-by: Pete Wyckoff ```